Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Torch RandCropByPosNegLabel, RandCropByPosNegLabeld, RandCropByLabelClasses, RandCropByLabelClassesd #2967

Merged
merged 3 commits into from
Sep 19, 2021
Merged

Torch RandCropByPosNegLabel, RandCropByPosNegLabeld, RandCropByLabelClasses, RandCropByLabelClassesd #2967

merged 3 commits into from
Sep 19, 2021

Conversation

rijobro
Copy link
Contributor

@rijobro rijobro commented Sep 17, 2021

Description

Torch RandCropByPosNegLabel, RandCropByPosNegLabeld, RandCropByLabelClasses, RandCropByLabelClassesd

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@rijobro
Torch RandCropByPosNegLabel, RandCropByPosNegLabeld, `RandCropByL…
e58d601 
…abelClasses`, `RandCropByLabelClassesd`

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro rijobro requested review from wyli and Nic-Ma September 17, 2021 10:53
@rijobro rijobro enabled auto-merge (squash) September 17, 2021 15:18
Nic-Ma
Nic-Ma approved these changes Sep 17, 2021
View reviewed changes
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, to cache the foreground & background indices for pos / neg crop, could you please help also add Tensor backend for FgBgToIndices transform?

Thanks in advance.

@rijobro rijobro mentioned this pull request Sep 17, 2021
Closed
wyli
wyli approved these changes Sep 19, 2021
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@Nic-Ma
Copy link
Contributor

Nic-Ma commented Sep 19, 2021

I tested with the spleen fast training notebook, every thing seems fine.

Thanks.

@rijobro rijobro merged commit e2e2d08 into Project-MONAI:dev Sep 19, 2021
@rijobro rijobro deleted the torch_rand_crop_by branch September 22, 2021 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@wyli wyli wyli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rijobro @Nic-Ma @wyli