Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Jupyter plotting #2964

Merged
merged 5 commits into from
Sep 16, 2021
Merged

Fix for Jupyter plotting #2964

merged 5 commits into from
Sep 16, 2021

Conversation

ericspod
Copy link
Member

Signed-off-by: Eric Kerfoot eric.kerfoot@kcl.ac.uk

Fixes # .

Description

This fixes an issue with the plotting in the Jupyter utilities relating to collated or decollated batches and having batches greater than 1.

Status

Work in progress

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

ericspod and others added 3 commits September 16, 2021 16:19
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
@ericspod
Copy link
Member Author

The current test fail looks like it has something to do with Matplotlib changing how it renders things since the content of the stored and generated images is the same, there are not changes to the plotting functions in this PR.

@wyli
Copy link
Contributor

wyli commented Sep 16, 2021

change the batch size will also change the loss curves, the expected image needs an update to match the new curve.

Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
@ericspod
Copy link
Member Author

There was a bit of variation in how the text was rendered as well and spacing somehow also changed. After accounting for the batch size these differences are still there.

@ericspod ericspod marked this pull request as ready for review September 16, 2021 22:06
@wyli wyli enabled auto-merge (squash) September 16, 2021 22:18
@wyli wyli merged commit 46e594f into Project-MONAI:dev Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants