Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Torch: map_binary_to_indices, map_classes_to_indices, correct_crop_centers, generate_pos_neg_label_crop_centers, generate_label_classes_crop_centers #2958

Merged
merged 7 commits into from
Sep 16, 2021

Conversation

rijobro
Copy link
Contributor

@rijobro rijobro commented Sep 15, 2021

Description

Torch: map_binary_to_indices, map_classes_to_indices, correct_crop_centers, generate_pos_neg_label_crop_centers, generate_label_classes_crop_centers

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

…generate_pos_neg_label_crop_centers, generate_label_classes_crop_centers

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro rijobro requested review from wyli and Nic-Ma September 15, 2021 17:37
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, @Nic-Ma this might change the behaviour of the spleen seg. notebook...please confirm

Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Could you please help double confirm by executing this example?
https://github.com/Project-MONAI/tutorials/blob/master/3d_segmentation/torch/unet_training_dict.py
Just also need to add EnsureTyped() after LoadImaged() to test with Tensor data.

Thanks in advance.

monai/transforms/croppad/array.py Show resolved Hide resolved
@wyli
Copy link
Contributor

wyli commented Sep 16, 2021

/build

wyli and others added 4 commits September 16, 2021 09:17
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro rijobro enabled auto-merge (squash) September 16, 2021 10:44
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@wyli
Copy link
Contributor

wyli commented Sep 16, 2021

/build

@rijobro rijobro merged commit 71ebd91 into Project-MONAI:dev Sep 16, 2021
@rijobro rijobro deleted the torch_transform_utils branch September 16, 2021 14:02
@Nic-Ma
Copy link
Contributor

Nic-Ma commented Sep 17, 2021

Hi @rijobro ,

Would you like to add Tensor support for RandCropByPosNegLabel and RandCropByLabelClasses with a high priority? As you already updated the help utilities.
And I think this PosNegCrop transform is popular in our training tasks, if we can support Tensor in v0.7, that would be great.

Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants