Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2231 Fixes tutorial 353 #2954

Merged
merged 14 commits into from
Sep 15, 2021
Merged

2231 Fixes tutorial 353 #2954

merged 14 commits into from
Sep 15, 2021

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Sep 15, 2021

Fixes Project-MONAI/tutorials#353
fixes Project-MONAI/tutorials#352
part of #2231

Description

  • enhance resampler to output tensor/nparray
  • enhance testing util to support type check
  • convert_to_dst_type with optional dtype

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli changed the title Fixes tutorial 353 2231 Fixes tutorial 353 Sep 15, 2021
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the fixes-tutorial-353 branch from 6443aa5 to 93ebdc3 Compare September 15, 2021 08:30
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the fixes-tutorial-353 branch from 8e41d48 to 26d8131 Compare September 15, 2021 10:22
@wyli wyli requested a review from Nic-Ma September 15, 2021 10:30
Signed-off-by: Wenqi Li <wenqil@nvidia.com>

 update

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the fixes-tutorial-353 branch from 2669fd3 to b303450 Compare September 15, 2021 10:33
@wyli wyli marked this pull request as ready for review September 15, 2021 10:40
@wyli wyli requested a review from rijobro September 15, 2021 10:40
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the fixes-tutorial-353 branch from b303450 to 91530fd Compare September 15, 2021 11:14
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Sep 15, 2021

/build

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the fixes-tutorial-353 branch from a8e9a1e to 3a07d02 Compare September 15, 2021 14:45
@wyli
Copy link
Contributor Author

wyli commented Sep 15, 2021

@Nic-Ma blossom ci passed, the GitHub tests were failing because of resources issue

Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick enhancement.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli enabled auto-merge (squash) September 15, 2021 20:39
@wyli wyli merged commit 0f17aa9 into Project-MONAI:dev Sep 15, 2021
@wyli wyli deleted the fixes-tutorial-353 branch November 18, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cron test error -- ./modules/transforms_demo_2d.ipynb cron test error -- ./modules/transfer_mmar.ipynb
2 participants