Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device to ToTensor #2926

Merged
merged 2 commits into from
Sep 11, 2021
Merged

Conversation

bhashemian
Copy link
Member

Fixes #2925

Description

Add device to ToTensor.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.

Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
@bhashemian bhashemian mentioned this pull request Sep 10, 2021
@bhashemian bhashemian requested review from Nic-Ma and wyli September 10, 2021 15:08
@wyli
Copy link
Contributor

wyli commented Sep 10, 2021

/build

@wyli
Copy link
Contributor

wyli commented Sep 10, 2021

/integration-test

Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, it looks good to me, a minor issue is that it introduces a style warning https://deepsource.io/gh/Project-MONAI/MONAI/run/9269f947-5bda-4b35-80ec-35af55955a22/python/PYL-R1705

Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration tests work fine

@bhashemian bhashemian merged commit 448cdca into Project-MONAI:dev Sep 11, 2021
@bhashemian bhashemian deleted the device-tensor branch September 11, 2021 10:59
@Nic-Ma Nic-Ma mentioned this pull request Sep 15, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ToTensor Device
3 participants