-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated RandKSpaceSpikeNoised. Collected Fourier mappings. #2665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oised. 1. Allow RandKSpaceSpikeNoised to work with arbitrary keys. 2. Introduced Fourier transform to keep the forward/backward fourier mappings. Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com>
Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com>
Ignore tests with versions of Pytorch which lack the module fft. Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com>
Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com>
wyli
approved these changes
Jul 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! looks good apart from the minor type hint issue, feel free to # type: ignore
/build |
Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com>
Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com>
Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com>
wyli
pushed a commit
to wyli/MONAI
that referenced
this pull request
Aug 3, 2021
…ONAI#2665) * Moved fourier functions to their own class. Modified RandKSpaceSpikeNoised. 1. Allow RandKSpaceSpikeNoised to work with arbitrary keys. 2. Introduced Fourier transform to keep the forward/backward fourier mappings. Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com> * removed old code Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com> * Ignore torch.fft tests if not present Ignore tests with versions of Pytorch which lack the module fft. Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com> * update Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com> * typing update Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com> * added unit test for Fourier Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com> * added unit test for Fourier Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com> * fixing black Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2642
Signed-off-by: Yaniel Cabrera yaniel.cabrera@gmail.com
Description
torch.fft
module now with@SkipIfNoModule("torch.fft")
in respective unit tests.Status
Work in progress
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests
.make html
command in thedocs/
folder.