Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated RandKSpaceSpikeNoised. Collected Fourier mappings. #2665

Merged
merged 10 commits into from
Aug 2, 2021

Conversation

yanielc
Copy link
Contributor

@yanielc yanielc commented Jul 28, 2021

Fixes #2642

Signed-off-by: Yaniel Cabrera yaniel.cabrera@gmail.com

Description

  1. Allow RandKSpaceSpikeNoised to work with arbitrary keys.
  2. Introduced Fourier transform to keep the forward/backward fourier mappings.
  3. Using torch.fft module now with @SkipIfNoModule("torch.fft") in respective unit tests.

Status

Work in progress

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

yanielc and others added 6 commits July 28, 2021 21:58
…oised.

1. Allow RandKSpaceSpikeNoised to work with arbitrary keys.
2. Introduced Fourier transform to keep the forward/backward fourier mappings.

Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com>
Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com>
Ignore tests with versions of Pytorch which lack the module fft.

Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com>
Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com>
Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com>
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! looks good apart from the minor type hint issue, feel free to # type: ignore

@madil90
Copy link
Contributor

madil90 commented Aug 2, 2021

/build

yanielc and others added 4 commits August 2, 2021 11:12
Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com>
Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com>
Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com>
@wyli wyli enabled auto-merge (squash) August 2, 2021 13:04
@wyli wyli merged commit 4f7371a into Project-MONAI:dev Aug 2, 2021
wyli pushed a commit to wyli/MONAI that referenced this pull request Aug 3, 2021
…ONAI#2665)

* Moved fourier functions to their own class. Modified RandKSpaceSpikeNoised.

1. Allow RandKSpaceSpikeNoised to work with arbitrary keys.
2. Introduced Fourier transform to keep the forward/backward fourier mappings.

Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com>

* removed old code

Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com>

* Ignore torch.fft tests if not present

Ignore tests with versions of Pytorch which lack the module fft.

Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com>

* update

Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com>

* typing update

Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com>

* added unit test for Fourier

Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com>

* added unit test for Fourier

Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com>

* fixing black

Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com>
@yanielc yanielc deleted the spikes_and_fourier branch February 6, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RandKSpaceSpikeNoised could be more generic
3 participants