Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GitHub based nightly pipeline #2629

Closed
wants to merge 2 commits into from
Closed

Conversation

madil90
Copy link
Contributor

@madil90 madil90 commented Jul 20, 2021

Part of #2628 .

Description

This PR deprecates the GitHub nightly pipeline. NVIDIA's internal CI/CD solution is running and testing MONAI pipeline

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@madil90 madil90 added the CI/CD label Jul 20, 2021
@madil90 madil90 requested review from wyli and Nic-Ma July 20, 2021 02:03
@madil90 madil90 self-assigned this Jul 20, 2021
wyli
wyli previously approved these changes Jul 20, 2021
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, could you sign the commit?

@madil90 madil90 force-pushed the remove_nightly_pipeline branch from 9380a05 to c87609d Compare July 22, 2021 17:18
@madil90
Copy link
Contributor Author

madil90 commented Jul 22, 2021

done

@wyli wyli dismissed their stale review July 22, 2021 17:33

pipeline issues

@wyli
Copy link
Contributor

wyli commented Jul 22, 2021

looks like we are still having some testing issues @madil90?



Running tests in folder: '.'                                                         
With file pattern: 'test_((?!integration).)'                                         
monai test runner: excluding tests.test_integration_classification_2d                
monai test runner: excluding tests.test_integration_determinism                      
monai test runner: excluding tests.test_integration_workflows                        
monai test runner: excluding tests.test_integration_sliding_window                   
monai test runner: excluding tests.test_integration_stn                              
monai test runner: excluding tests.test_integration_unet_2d                          
monai test runner: excluding tests.test_integration_segmentation_3d                  
monai test runner: excluding tests.test_integration_workflows_gan                    
Traceback (most recent call last):                                                   
  File "./tests/runner.py", line 133, in <module>                                    
    tests = unittest.TestLoader().loadTestsFromNames(cases)                          
  File "/opt/conda/lib/python3.8/unittest/loader.py", line 220, in loadTestsFromNames     
    suites = [self.loadTestsFromName(name, module) for name in names]                
  File "/opt/conda/lib/python3.8/unittest/loader.py", line 220, in <listcomp>        
    suites = [self.loadTestsFromName(name, module) for name in names]                
  File "/opt/conda/lib/python3.8/unittest/loader.py", line 154, in loadTestsFromName     
    module = __import__(module_name)                                                                                         
  File "/tmp/tmp.Lw7YoQlEiC/tests/test_bending_energy.py", line 25, in <module>      
    {"pred": torch.ones((1, 3, 5, 5, 5), device=device)},                            
RuntimeError: CUDA error: no kernel image is available for execution on the device     
CUDA kernel errors might be asynchronously reported at some other API call,so the stacktrace below might be incorrect.     
For debugging consider passing CUDA_LAUNCH_BLOCKING=1. 

Signed-off-by: Mohammad Adil <madil@nvidia.com>
@madil90 madil90 force-pushed the remove_nightly_pipeline branch from c87609d to fa7b0c2 Compare July 23, 2021 02:59
@madil90
Copy link
Contributor Author

madil90 commented Jul 23, 2021

@wyli Which test is this? This PR doesn't contain any code changes.

Perhaps they were due to outdated branch. I've rebased it and re-running tests.

@madil90
Copy link
Contributor Author

madil90 commented Jul 23, 2021

/build

4 similar comments
@madil90
Copy link
Contributor Author

madil90 commented Jul 23, 2021

/build

@madil90
Copy link
Contributor Author

madil90 commented Aug 2, 2021

/build

@madil90
Copy link
Contributor Author

madil90 commented Aug 2, 2021

/build

@madil90
Copy link
Contributor Author

madil90 commented Aug 3, 2021

/build

@madil90 madil90 closed this Aug 6, 2021
@madil90 madil90 deleted the remove_nightly_pipeline branch August 6, 2021 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants