-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
torch default for Flip #2263
Closed
Closed
torch default for Flip #2263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
ericspod
reviewed
May 27, 2021
monai/transforms/transform.py
Outdated
orig_type = type(data) | ||
assert orig_type in (torch.Tensor, np.ndarray) | ||
|
||
if orig_type is np.ndarray and required_type is torch.Tensor: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can put this conversion block into a separate utility function somewhere:
def convert_data_type(data, current_type, required_type):
if current_type is np.ndarray and required_type is torch.Tensor:
return torch.Tensor(data)
elif current_type is torch.Tensor and required_type is np.ndarray:
return data.detach().cpu().numpy()
return data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point, done.
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Addressed by #2822 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Starts to address: #2231.
To base class convert to/from numpy as necessary, and then convert back to the original at the end. Use torch for the main functionality.
This is an example case for the rest of the transforms.
I also created a class to contain types frequently used in our transforms:
By using these, we should be better able to unify our transforms (some only have
np.ndarray
, some usetorch.Tensor
, some have both).Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests
.make html
command in thedocs/
folder.