Enhance smartcache doc-string and unit test #2105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge master
merge master
merge master
Signed-off-by: Nic Ma <nma@nvidia.com>
|
/black |
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
|
/black |
Signed-off-by: Nic Ma <nma@nvidia.com>
|
/black |
wyli
approved these changes
Apr 28, 2021
wyli
pushed a commit
that referenced
this pull request
May 26, 2021
* [DLMED] Enhance unit test and doc-string Signed-off-by: Nic Ma <nma@nvidia.com> * [MONAI] python code formatting Signed-off-by: monai-bot <monai.miccai2019@gmail.com> * [DLMED] enhance unit test Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] fix CI test issue Signed-off-by: Nic Ma <nma@nvidia.com> Co-authored-by: monai-bot <monai.miccai2019@gmail.com>
wyli
pushed a commit
that referenced
this pull request
May 26, 2021
* [DLMED] Enhance unit test and doc-string Signed-off-by: Nic Ma <nma@nvidia.com> * [MONAI] python code formatting Signed-off-by: monai-bot <monai.miccai2019@gmail.com> * [DLMED] enhance unit test Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] fix CI test issue Signed-off-by: Nic Ma <nma@nvidia.com> Co-authored-by: monai-bot <monai.miccai2019@gmail.com>
wyli
pushed a commit
that referenced
this pull request
May 26, 2021
* [DLMED] Enhance unit test and doc-string Signed-off-by: Nic Ma <nma@nvidia.com> * [MONAI] python code formatting Signed-off-by: monai-bot <monai.miccai2019@gmail.com> * [DLMED] enhance unit test Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] fix CI test issue Signed-off-by: Nic Ma <nma@nvidia.com> Co-authored-by: monai-bot <monai.miccai2019@gmail.com>
wyli
pushed a commit
that referenced
this pull request
May 27, 2021
* [DLMED] Enhance unit test and doc-string Signed-off-by: Nic Ma <nma@nvidia.com> * [MONAI] python code formatting Signed-off-by: monai-bot <monai.miccai2019@gmail.com> * [DLMED] enhance unit test Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] fix CI test issue Signed-off-by: Nic Ma <nma@nvidia.com> Co-authored-by: monai-bot <monai.miccai2019@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thanks for Ahmed's feedback, this PR enhanced the doc-string of
SmartCacheDatasetand added unit test to cover thepersistent_workersof PyTorch DataLaoder.Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.