Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1545 upgrade base image to pytorch 20.12 #1613

Merged
merged 6 commits into from
Feb 23, 2021
Merged

1545 upgrade base image to pytorch 20.12 #1613

merged 6 commits into from
Feb 23, 2021

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Feb 22, 2021

Fixes #1545

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

wyli added 4 commits February 22, 2021 16:04
@wyli
test new image
96d8e5f 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
temp no cron
75f20b4 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
fixes unit tests
6a7505e 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
adds base docker test
1f4a985 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli requested review from madil90 and Nic-Ma February 22, 2021 18:22
@wyli
undo temp tests
f707b80 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli changed the title upgrade base image to pytorch 20.12 1545 upgrade base image to pytorch 20.12 Feb 22, 2021
@wyli
Copy link
Contributor Author

wyli commented Feb 22, 2021

https://github.com/Project-MONAI/MONAI/runs/1954911641?check_suite_focus=true Passed full CI

Nic-Ma
Nic-Ma approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thanks.

@wyli wyli enabled auto-merge (squash) February 23, 2021 07:50
@wyli wyli merged commit 75b78cd into master Feb 23, 2021
@wyli wyli deleted the test-20-12 branch February 23, 2021 09:03
This was referenced Feb 23, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@madil90 madil90 Awaiting requested review from madil90

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

upgrade base image to pytorch 20.12
2 participants
@wyli @Nic-Ma