Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1556 Optimize the numpy computation for spatial axes #1572

Merged
merged 9 commits into from
Feb 9, 2021

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Feb 9, 2021

Fixes #1556 .

Description

This PR optimized the numpy computation with a mapping utility for spatial axes.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 9, 2021

/black

Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma Nic-Ma force-pushed the 1556-simplify-redundent-trans branch from a7468ea to 5ce3ea4 Compare February 9, 2021 13:24
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 9, 2021

/black

Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma Nic-Ma requested a review from wyli February 9, 2021 14:31
@wyli wyli merged commit 910b1d4 into Project-MONAI:master Feb 9, 2021
@Nic-Ma Nic-Ma deleted the 1556-simplify-redundent-trans branch July 2, 2021 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Random flip per channel seems redundant
2 participants