Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1478 Fix TorchScript issue in AHNet with PyTorch 1.5 #1538

Merged
merged 6 commits into from
Feb 2, 2021
Merged

1478 Fix TorchScript issue in AHNet with PyTorch 1.5 #1538

merged 6 commits into from
Feb 2, 2021

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Feb 2, 2021

Fixes #1478 .

Description

This PR fixed the TorchScript export issue in AHNet with PyTorch 1.5.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Nic-Ma and others added 5 commits January 21, 2021 18:19
@Nic-Ma
Merge pull request #13 from Project-MONAI/master
5e3d575 
merge master
@Nic-Ma
[DLMED] fix TorchScript issue in AHNet
7c9d4dc 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
[DLMED] add test cases
8aa2acf 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Merge pull request #21 from Project-MONAI/master
dcf58c3 
merge master
@Nic-Ma
[DLMED] fix torchscript issue in PyTorch 1.5
c6d30c3 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 2, 2021

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 2, 2021

I already tested locally with PyTorch 1.5.
Thanks.

wyli
wyli approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wyli wyli merged commit 97ff1e0 into Project-MONAI:master Feb 2, 2021
@Nic-Ma Nic-Ma deleted the 1478-fix-torchscript-ahnet branch July 2, 2021 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

@atbenmurray atbenmurray Awaiting requested review from atbenmurray

@ericspod ericspod Awaiting requested review from ericspod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TorchScript can't work for AHNet when num_psp=0
2 participants
@Nic-Ma @wyli