Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1512 rand_gaussian_noised with multiple keys #1530

Merged
merged 7 commits into from
Feb 2, 2021

Conversation

rijobro
Copy link
Contributor

@rijobro rijobro commented Feb 1, 2021

Fixes #1512.

Description

Create a list of noise realisations, with length equal to the number of keys. The noise realisations can all use the same mean, or a mean can be specified for each of the keys. The unit test has been updated to run for multiple labels.

@LucasFidon Does this suitably solve your problem?

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro rijobro requested review from wyli and Nic-Ma February 1, 2021 09:59
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@LucasFidon
Copy link
Contributor

Hi @rijobro
Yes, this solves #1512, thank you for looking at this!

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wyli wyli merged commit 5e8d2a9 into Project-MONAI:master Feb 2, 2021
@rijobro rijobro deleted the rand_gaussian_noised branch March 5, 2021 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shape mismatch ValueError when using RandGaussianNoised with more than one key
4 participants