Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1452 adjust-warp-layer-grid-pull-user-case #1470

Merged
merged 8 commits into from
Jan 28, 2021
Merged

1452 adjust-warp-layer-grid-pull-user-case #1470

merged 8 commits into from
Jan 28, 2021

Conversation

kate-sann5100
Copy link
Collaborator

@kate-sann5100 kate-sann5100 commented Jan 19, 2021 •
edited
Loading

Signed-off-by: kate-sann5100 yiwen.li@st-annes.ox.ac.uk

Fixes #1452 .

Description

use pull-grid only for above linear interpolation

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

kate-sann5100 and others added 8 commits January 19, 2021 15:43
@kate-sann5100
1442 use pull-grid only for above linear interpolation
e1a4c12 
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
@kate-sann5100
1452 reformat
87fe559 
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
@kate-sann5100
1452 adjust test
b0b7fc7 
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
@kate-sann5100
1452 reformat
74245d0 
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
@kate-sann5100
1452 raise ValueError for mode > 1
282d891 
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
@kate-sann5100
1452 reformat
a9496a1 
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
@kate-sann5100
1452 reformat
c98b41d 
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
@kate-sann5100
Merge branch 'master' into 1452-adjust-warp-layer-grid-pull-user-case
5dd1b31
@kate-sann5100 kate-sann5100 changed the title [WIP]1452 adjust-warp-layer-grid-pull-user-case 1452 adjust-warp-layer-grid-pull-user-case Jan 27, 2021
wyli
wyli approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! this pr temporarily removes the high order interpolation support in the warp class

@wyli wyli merged commit f75b67a into Project-MONAI:master Jan 28, 2021
@wyli wyli mentioned this pull request Mar 29, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add warp layer
2 participants
@kate-sann5100 @wyli