Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1452 warp layer #1463

Merged
merged 4 commits into from
Jan 19, 2021
Merged

1452 warp layer #1463

merged 4 commits into from
Jan 19, 2021

Conversation

kate-sann5100
Copy link
Collaborator

@kate-sann5100 kate-sann5100 commented Jan 18, 2021 •
edited
Loading

Fixes #1452 .

Description

Add Warp layer to warp image with DDF.

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@kate-sann5100
1452 add Warp layer and test
adcf47b 
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
@kate-sann5100
1452 add documentation
691233f 
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
@kate-sann5100
Merge remote-tracking branch 'Project-MONAI/master' into 1452-warp-layer
0a33908
wyli
wyli reviewed Jan 18, 2021
View reviewed changes
tests/test_warp.py Outdated Show resolved Hide resolved
@kate-sann5100
1452 enforce same image and ddf size, add test case
70a4847 
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
wyli
wyli approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks the components look fine, need some further tests for the gradients, especially for the consistency w/o the use-compiled flag

@wyli wyli merged commit b26cc24 into Project-MONAI:master Jan 19, 2021
@tvercaut tvercaut mentioned this pull request Jan 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add warp layer
2 participants
@kate-sann5100 @wyli