Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing c++ PHL Implementation in Python API #1453

Merged
merged 15 commits into from
Jan 18, 2021

Conversation

charliebudd
Copy link
Collaborator

Required for #315 (further work needed)

Description

Exposes an efficient c++ and cuda implementation of the permutohedral lattice based filtering method discussed here...
https://graphics.stanford.edu/papers/permutohedral/

This was initialy implemented as an option for the back end of a bilateral filter. This PR is just exposing that functionality to allow other use cases.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: charliebudd <charles.budd@kcl.ac.uk>
Signed-off-by: charliebudd <charles.budd@kcl.ac.uk>
Signed-off-by: charliebudd <charles.budd@kcl.ac.uk>
Signed-off-by: charliebudd <charles.budd@kcl.ac.uk>
Signed-off-by: charliebudd <charles.budd@kcl.ac.uk>
Signed-off-by: charliebudd <charles.budd@kcl.ac.uk>
@charliebudd charliebudd requested a review from wyli January 15, 2021 11:43
Signed-off-by: charliebudd <charles.budd@kcl.ac.uk>
Signed-off-by: charliebudd <charles.budd@kcl.ac.uk>
Signed-off-by: charliebudd <charles.budd@kcl.ac.uk>
Signed-off-by: charliebudd <charles.budd@kcl.ac.uk>
Signed-off-by: charliebudd <charles.budd@kcl.ac.uk>
@wyli
Copy link
Contributor

wyli commented Jan 18, 2021

/black

monai-bot and others added 2 commits January 18, 2021 16:13
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
Signed-off-by: charliebudd <charles.budd@kcl.ac.uk>
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wyli wyli merged commit bf8f8e2 into Project-MONAI:master Jan 18, 2021
@charliebudd charliebudd deleted the phl-exposure branch January 19, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants