Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

norm_eps defined in class SPADEResBlock init is not used #7946

Closed
mingxin-zheng opened this issue Jul 24, 2024 · 0 comments
Closed

norm_eps defined in class SPADEResBlock init is not used #7946

mingxin-zheng opened this issue Jul 24, 2024 · 0 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@mingxin-zheng
Copy link
Contributor

Describe the bug

In the init of SPADEResBlock

norm_eps was defined but not used in the class methods.

To Reproduce
Steps to reproduce the behavior:
None

Expected behavior
The SPADE layer should take the eps for the GroupNorm:
Current:

        self.norm1 = SPADE(
            label_nc=label_nc,
            norm_nc=in_channels,
            norm="GROUP",
            norm_params={"num_groups": norm_num_groups, "affine": False},
            hidden_channels=spade_intermediate_channels,
            kernel_size=3,
            spatial_dims=spatial_dims,
        )

Expected:

        self.norm1 = SPADE(            
            label_nc=label_nc,            
            norm_nc=in_channels,            
            norm="GROUP",            
            norm_params={"num_groups": norm_num_groups, "affine": False, "eps": norm_eps},            
            hidden_channels=spade_intermediate_channels,            
            kernel_size=3,            
            spatial_dims=spatial_dims,        
        )
@KumoLiu KumoLiu added bug Something isn't working good first issue Good for newcomers labels Jul 24, 2024
virginiafdez pushed a commit to virginiafdez/MONAI that referenced this issue Jul 29, 2024
…to issue Project-MONAI#7946.

Signed-off-by: Virginia Fernandez <vf19@lihe044-pc.isd.kcl.ac.uk>
KumoLiu pushed a commit that referenced this issue Jul 30, 2024
Fixes # .

### Description

Addition of norm_eps to spade_autoencoderkl.py as per
#7946.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: Virginia Fernandez <vf19@lihe044-pc.isd.kcl.ac.uk>
Signed-off-by: Virginia Fernandez <virginia.fernandez@kcl.ac.uk>
Co-authored-by: Virginia Fernandez <vf19@lihe044-pc.isd.kcl.ac.uk>
Co-authored-by: Virginia Fernandez <virginia.fernandez@kcl.ac.uk>
virginiafdez pushed a commit to virginiafdez/MONAI that referenced this issue Jul 31, 2024
…to issue Project-MONAI#7946.

Signed-off-by: Virginia Fernandez <virginia.fernandez@kcl.ac.uk>
@ericspod ericspod closed this as completed Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants