Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "properties_path" in BundleWorkflow #7541

Closed
KumoLiu opened this issue Mar 13, 2024 · 0 comments · Fixed by #7542
Closed

Add "properties_path" in BundleWorkflow #7541

KumoLiu opened this issue Mar 13, 2024 · 0 comments · Fixed by #7542
Assignees

Comments

@KumoLiu
Copy link
Contributor

KumoLiu commented Mar 13, 2024

  • Add "properties_path" in BundleWorkflow for user to add customized properties.
  • Remove ignite based properties in the default properties, since after add properties_path, we can define package-specific properties.
@KumoLiu KumoLiu self-assigned this Mar 13, 2024
KumoLiu added a commit that referenced this issue Apr 1, 2024
Fixes #7541


### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant