Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bundle download API -- change deprecated since="1.3" to since="1.2" #7015

Closed
wyli opened this issue Sep 20, 2023 · 1 comment · Fixed by #7016
Closed

bundle download API -- change deprecated since="1.3" to since="1.2" #7015

wyli opened this issue Sep 20, 2023 · 1 comment · Fixed by #7016
Assignees
@KumoLiu

Comments

@wyli
Copy link
Contributor

wyli commented Sep 20, 2023

before 1.3 is released and tagged, it's not possible to properly test these deprecation decorator. would be great to change them to since="1.2" to reflect the actual changes across versions.

MONAI/monai/bundle/scripts.py

Line 624 in e5f9337

@deprecated_arg_default("tag", "hosting_storage_v1", "dev", since="1.3", replaced="1.5")

MONAI/monai/bundle/scripts.py

Line 662 in e5f9337

@deprecated_arg_default("tag", "hosting_storage_v1", "dev", since="1.3", replaced="1.5")

MONAI/monai/bundle/scripts.py

Line 707 in e5f9337

@deprecated_arg("runner_id", since="1.1", removed="1.3", new_name="run_id", msg_suffix="please use `run_id` instead.")

@wyli
Copy link
Contributor Author

wyli commented Sep 20, 2023

introduced in 73a7601, could you please help with this? @KumoLiu

@KumoLiu KumoLiu self-assigned this Sep 20, 2023
KumoLiu added a commit to KumoLiu/MONAI that referenced this issue Sep 20, 2023
@KumoLiu
fix Project-MONAI#7015
08d9366 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu KumoLiu mentioned this issue Sep 20, 2023
Merged
6 tasks
wyli pushed a commit that referenced this issue Sep 20, 2023
@KumoLiu
Change deprecated since="1.3" to since="1.2" (#7016)
2a0ed97 
Fixes #7015.

### Description
Change deprecated since="1.3" to since="1.2" before 1.3 is released and
tagged.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: KumoLiu <yunl@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KumoLiu KumoLiu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change deprecated since="1.3" to since="1.2" KumoLiu/MONAI
2 participants
@wyli @KumoLiu