Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init_bundle Should Put License File in docs #6964

Closed
ericspod opened this issue Sep 8, 2023 · 2 comments · Fixed by #7014
Closed

init_bundle Should Put License File in docs #6964

ericspod opened this issue Sep 8, 2023 · 2 comments · Fixed by #7014
Labels
Bundles Anything related to bundles

Comments

@ericspod
Copy link
Member

ericspod commented Sep 8, 2023

Is your feature request related to a problem? Please describe.
When init_bundle is used to create a new bundle directory it should put the temp license file in docs instead of the root.
@ericspod ericspod added the Bundles Anything related to bundles label Sep 8, 2023
@ericspod ericspod moved this to Bundle Todo in MONAI v1.3 Sep 8, 2023
@wyli
Copy link
Contributor

wyli commented Sep 11, 2023 •
edited
Loading

currently the model zoo items have the LICENCE in at the root directory and data_license.txt in the docs/ https://github.com/Project-MONAI/model-zoo/blob/dev/CONTRIBUTING.md#license-format init_bundle is currently following this format..

@ericspod
Copy link
Member Author

The specification has the file in docs. That seems neater to me but if that's not wanted we should change the spec then.

@KumoLiu KumoLiu mentioned this issue Sep 20, 2023
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from Bundle Todo to Done in MONAI v1.3 Sep 25, 2023
wyli pushed a commit that referenced this issue Sep 25, 2023
@KumoLiu
Add LICENSE requirement in spec (#7014)
cc3faa3 
Fixes #6964.

### Description
Add LICENSE requirement in specification.

https://github.com/Project-MONAI/model-zoo/blob/bdd183ebc113a70d50db4e4fb2ebd9a7c8c7532b/ci/verify_bundle.py#L28

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: KumoLiu <yunl@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bundles Anything related to bundles
Projects
No open projects
MONAI v1.3
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add LICENSE requirement in spec KumoLiu/MONAI
2 participants
@wyli @ericspod