Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update monai.bundle to support model zoo NGC hosting #6761

Closed
yiheng-wang-nv opened this issue Jul 24, 2023 · 2 comments · Fixed by #6828
Closed

Update monai.bundle to support model zoo NGC hosting #6761

yiheng-wang-nv opened this issue Jul 24, 2023 · 2 comments · Fixed by #6828
Assignees
@KumoLiu

Comments

@yiheng-wang-nv
Copy link
Contributor

Related changes in model zoo:
Project-MONAI/model-zoo#463

I will add more information later
@yiheng-wang-nv
Copy link
Contributor Author

cc @wyli

@yiheng-wang-nv yiheng-wang-nv self-assigned this Jul 25, 2023
@yiheng-wang-nv
Copy link
Contributor Author

cc @KumoLiu

@KumoLiu KumoLiu assigned KumoLiu and unassigned yiheng-wang-nv Aug 6, 2023
@KumoLiu KumoLiu mentioned this issue Aug 7, 2023
Merged
7 tasks
@wyli wyli closed this as completed in #6828 Aug 7, 2023
wyli pushed a commit that referenced this issue Aug 7, 2023
@KumoLiu
Update monai.bundle to support model zoo NGC hosting (#6828)
5e6ce7c 
Fixes #6761 .

### Description

- update `download` to support monaihosting download.
- update relevant unit tests.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu KumoLiu mentioned this issue Aug 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KumoLiu KumoLiu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update monai.bundle to support model zoo NGC hosting KumoLiu/MONAI
2 participants
@KumoLiu @yiheng-wang-nv