Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LRFinder range_test has incorrect type annotation for end_lr #6363

Closed
joshestein opened this issue Apr 14, 2023 · 0 comments · Fixed by #6364
Closed

LRFinder range_test has incorrect type annotation for end_lr #6363

joshestein opened this issue Apr 14, 2023 · 0 comments · Fixed by #6364

Comments

@joshestein
Copy link
Contributor

Describe the bug
The end_lr parameter is annotated as an int. However, it is used for two underlying schedulers that inherit from _LRSchedulerMonai, which uses a float.

Expected behavior
end_lr should be annotated as a float.
@joshestein joshestein changed the title LearningRateFinder range_test has incorrect type annotation for end_lr LRFinder range_test has incorrect type annotation for end_lr Apr 14, 2023
@joshestein joshestein mentioned this issue Apr 14, 2023
Merged
1 task
wyli pushed a commit that referenced this issue Apr 14, 2023
@joshestein
int -> float type annotation for LRFinder (#6364)
7bb74c6 
Fixes #6363.

### Description

Correct type annotation for `end_lr`.

### Types of changes

- [x] Non-breaking change (fix or new feature that would not break
existing functionality).

Signed-off-by: Josh <josh.e.stein@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

int -> float type annotation for LRFinder
1 participant
@joshestein