-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_auto3dseg_ensemble #6155
Comments
the same test might have some memory issue as well
|
Need to discuss with @dongyang0122 . I am inclined to update the algorithm templates. What do you think @dongyang0122 ? |
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Which version of PyTorch should we use for developing to pass the unit test? |
We are using PyTorch 1.8 - 1.13. I think the PyTorch 1.8-1.12 tests are optional during the PR. |
Is it viable to detect the version of PyTorch in dints Auto3DSeg templates, and fall back to the previous scheduler if it is not causing too much of performance decrease? I'm also okay to skip the tests for now, but it will mean PyTorch 1.12 users will not be able to use Auto3DSeg. |
I may need to re-write the scheduler logic manually to avoid the version issue. |
ok, let's keep this ticket open and I'll make a workaround to skip the tests for torch <=1.12 to unblock the release candidate |
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
the related tutorials https://github.com/Project-MONAI/tutorials are also broken
|
Hi @dongyang0122 @wyli , The main issue there was that the class script is from PyTorch. So I include the full license in the script for legal. |
PolynomialLR is new in torch 1.13 which breaks tests with earlier versions of pytorch
issue introduced by af46d7b @mingxin-zheng @dongyang0122 could you please have a look soon? skip the test or update the algo
The text was updated successfully, but these errors were encountered: