Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: helm chart service label indentation issues #768

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

liymike
Copy link

@liymike liymike commented Jan 2, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

This pull request fixes an indentation issue in the labels section under

device-plugin/monitorservice.yaml
scheduler/service.yaml

in the Helm chart.

Which issue(s) this PR fixes:
Fixes #

Currently, the custom service labels are indented with 4 extra spaces, which is inconsistent with the other labels like below.

apiVersion: v1
kind: Service
metadata:
  name: hami-device-plugin-monitor
  labels:
    app.kubernetes.io/component: hami-device-plugin
    helm.sh/chart: hami-2.4.1
    app.kubernetes.io/name: hami
    app.kubernetes.io/instance: hami
    app.kubernetes.io/version: "2.4.1"
    app.kubernetes.io/managed-by: Helm
        monitored-by: vm

This PR corrects the indentation to align with the rest of the labels.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant