Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

story #12308 update to angular 13 #1894

Merged
merged 3 commits into from
Jun 20, 2024
Merged

story #12308 update to angular 13 #1894

merged 3 commits into from
Jun 20, 2024

Conversation

Regzox
Copy link
Contributor

@Regzox Regzox commented Jun 6, 2024

Description

Description des modifications

Type de changement

Indiquer le ou les types de changements

  • Build
  • PKI
  • Ansiblerie
  • Nouveau Code
  • Correction
  • Refactorisation de code
  • Autre

Documentation

Indiquer la documentation mise à jour

  • Quels sont les nouvelles documentations ?
  • Quels sont les modifications existantes ?
  • Quels sont les documentations ou sections de documentations supprimés ?

Tests

Indiquer comment le code à été testé (manuel, environnement, TU, etc)

  • manuel
  • environnement
  • TU

Migration

Indiquer si les modifications apportées impliquent une migration sur l'existant et comment la faire

Checklist

Sélectionner les éléments de la checklist

  • Mon code suit le style de code de ce projet.
  • J'ai commenté mon code, en particulier dans les classes et les méthodes difficile à comprendre.
  • J'ai fait les changements correspondant dans la documentation RAML.
  • J'ai fait les changements correspondant dans la documentation Métier.
  • J'ai fait les changements correspondant dans la documentation Technique.
  • J'ai rajouté les tests unitaires vérifiant mes fonctionnalités.
  • J'ai rajouté les tests de non régression vérifiant mes fonctionnalités.
  • Les tests unitaires nouveaux et existants passent avec succès localement.
  • Toutes les dépendances ont été mergées en priorité

Contributeur

Indiquer qui a développé cette fonctionnalité

  • VAS (Vitam Accessible en Service)
  • CEA (Commissariat à l'énergie atomique et aux énergies alternatives)

@Regzox Regzox marked this pull request as draft June 6, 2024 14:34
@vitam-devops
Copy link
Collaborator

vitam-devops commented Jun 6, 2024 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 12104a6b-3e6c-4178-a0cf-46875024385f

New Issues

Severity Issue Source File / Package Checkmarx Insight
HIGH CVE-2019-15599 Npm-tree-kill-1.2.1 Vulnerable Package
HIGH CVE-2020-28502 Npm-xmlhttprequest-ssl-1.5.5 Vulnerable Package
HIGH CVE-2020-36048 Npm-engine.io-3.2.1 Vulnerable Package
HIGH CVE-2020-36049 Npm-socket.io-parser-3.2.0 Vulnerable Package
HIGH CVE-2020-7660 Npm-serialize-javascript-1.9.1 Vulnerable Package
HIGH CVE-2020-7788 Npm-ini-1.3.5 Vulnerable Package
HIGH CVE-2021-31597 Npm-xmlhttprequest-ssl-1.5.5 Vulnerable Package
HIGH CVE-2022-2421 Npm-socket.io-parser-3.2.0 Vulnerable Package
HIGH CVE-2023-45133 Npm-babel-traverse-6.26.0 Vulnerable Package
HIGH Cx3b412226-50de Npm-d3-color-1.4.1 Vulnerable Package
MEDIUM CVE-2019-16769 Npm-serialize-javascript-1.9.1 Vulnerable Package
MEDIUM CVE-2020-15366 Npm-ajv-6.10.0 Vulnerable Package
MEDIUM CVE-2020-15366 Npm-ajv-5.5.2 Vulnerable Package
MEDIUM CVE-2020-28481 Npm-socket.io-2.1.1 Vulnerable Package
MEDIUM CVE-2020-7693 Npm-sockjs-0.3.19 Vulnerable Package
MEDIUM CVE-2021-23364 Npm-browserslist-4.5.5 Vulnerable Package
MEDIUM CVE-2022-21704 Npm-log4js-4.5.1 Vulnerable Package
MEDIUM CVE-2022-41940 Npm-engine.io-3.2.1 Vulnerable Package
MEDIUM Unpinned Actions Full Length Commit SHA /build-and-test.yml: [120](https://github.com/ProgrammeVitam/vitam-ui/blob/angular_13_upgrade//.github/workflows/build-and-test.yml# L120) Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-and-test.yml: [34](https://github.com/ProgrammeVitam/vitam-ui/blob/angular_13_upgrade//.github/workflows/build-and-test.yml# L34) Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-and-test.yml: [125](https://github.com/ProgrammeVitam/vitam-ui/blob/angular_13_upgrade//.github/workflows/build-and-test.yml# L125) Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-and-test.yml: [76](https://github.com/ProgrammeVitam/vitam-ui/blob/angular_13_upgrade//.github/workflows/build-and-test.yml# L76) Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-and-test.yml: [58](https://github.com/ProgrammeVitam/vitam-ui/blob/angular_13_upgrade//.github/workflows/build-and-test.yml# L58) Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Logging of Sensitive Data /ansible.cfg: [2](https://github.com/ProgrammeVitam/vitam-ui/blob/angular_13_upgrade//tools/docker/mongo/ansible.cfg# L2) To keep sensitive values out of logs, tasks that expose them need to be marked defining 'no_log' and setting to True
LOW Logging of Sensitive Data /ansible.cfg: [1](https://github.com/ProgrammeVitam/vitam-ui/blob/angular_13_upgrade//deployment/ansible.cfg# L1) To keep sensitive values out of logs, tasks that expose them need to be marked defining 'no_log' and setting to True
LOW Logging of Sensitive Data /ansible.cfg: [2](https://github.com/ProgrammeVitam/vitam-ui/blob/angular_13_upgrade//deployment/pki/scripts/lib/ansible.cfg# L2) To keep sensitive values out of logs, tasks that expose them need to be marked defining 'no_log' and setting to True

Fixed Issues

Severity Issue Source File / Package
HIGH CVE-2023-28154 Npm-webpack-5.50.0
MEDIUM Unpinned Actions Full Length Commit SHA /build-and-test.yml: [77](https://github.com/ProgrammeVitam/vitam-ui/blob/angular_13_upgrade//.github/workflows/build-and-test.yml# L77)
MEDIUM Unpinned Actions Full Length Commit SHA /build-and-test.yml: [121](https://github.com/ProgrammeVitam/vitam-ui/blob/angular_13_upgrade//.github/workflows/build-and-test.yml# L121)
MEDIUM Unpinned Actions Full Length Commit SHA /build-and-test.yml: [36](https://github.com/ProgrammeVitam/vitam-ui/blob/angular_13_upgrade//.github/workflows/build-and-test.yml# L36)
MEDIUM Unpinned Actions Full Length Commit SHA /build-and-test.yml: [60](https://github.com/ProgrammeVitam/vitam-ui/blob/angular_13_upgrade//.github/workflows/build-and-test.yml# L60)
MEDIUM Unpinned Actions Full Length Commit SHA /build-and-test.yml: [126](https://github.com/ProgrammeVitam/vitam-ui/blob/angular_13_upgrade//.github/workflows/build-and-test.yml# L126)

marob
marob reviewed Jun 6, 2024
View reviewed changes
@Regzox Regzox force-pushed the angular_13_upgrade branch 5 times, most recently from 40aa5a0 to bf4bae1 Compare June 10, 2024 10:30
ebernard
ebernard reviewed Jun 10, 2024
View reviewed changes
Copy link
Contributor

@ebernard ebernard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extraire les sujets n'ayant pas de rapport avec l'upgrade angular dans une autre PR

@Regzox Regzox force-pushed the angular_13_upgrade branch 3 times, most recently from ca649aa to 0020e38 Compare June 11, 2024 14:19
@Regzox Regzox marked this pull request as ready for review June 11, 2024 14:19
@Regzox Regzox force-pushed the angular_13_upgrade branch from 0020e38 to 423bea7 Compare June 11, 2024 17:08
marob
marob reviewed Jun 17, 2024
View reviewed changes
@Regzox Regzox force-pushed the angular_13_upgrade branch 2 times, most recently from f90f237 to 5ff8faf Compare June 17, 2024 12:48
marob
marob reviewed Jun 17, 2024
View reviewed changes
@Regzox Regzox force-pushed the angular_13_upgrade branch 4 times, most recently from d04d0a6 to 1b19f28 Compare June 17, 2024 15:48
@Regzox Regzox changed the title Angular 13 upgrade story #12308 update to angular 13 Jun 17, 2024
@Regzox Regzox force-pushed the angular_13_upgrade branch from 1b19f28 to 2c61be6 Compare June 18, 2024 08:31
Regzox added 2 commits June 18, 2024 16:42
@Regzox
story #12308 build: update to angular 13
309a818 
upgrade angular material to 13

remove extractCss

remove tilde from use angular/material imports scss

update @angular-builders/custom-webpack to

ignore angular cache

update oauth2 & svg-icon

update @ngx-translate-core & translate-http-loader

update ngx-ui-loader

remove ng2-nvd3

remove flag-icon-css

fix(angular@13): remove not supported umdModuleIds

add source map for default builds (dev)

fix moment imports

fix async test

add scss schema to vitamui-library

set component default schema scss for all modules

remove msSaveOrOpenBlob occurences
@Regzox
story #12308 fix(pastis): d3.js version and usage
21c0580
@Regzox Regzox force-pushed the angular_13_upgrade branch from dbd47d3 to 21c0580 Compare June 18, 2024 14:45
@ebernard ebernard merged commit 4bd5cbe into develop Jun 20, 2024
8 checks passed
@ebernard ebernard deleted the angular_13_upgrade branch June 20, 2024 12:52
@marob marob added this to the IT 137 milestone Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebernard ebernard ebernard approved these changes

@marob marob marob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
IT 137
Development

Successfully merging this pull request may close these issues.
4 participants
@Regzox @vitam-devops @ebernard @marob