Add tests

ProfessionalWiki · Apr 24, 2024 · 9dac057 · 9dac057
1 parent 345207e
commit 9dac057
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 2 deletions.
diff --git a/src/PackagePrivate/Parser/Parser.php b/src/PackagePrivate/Parser/Parser.php
@@ -209,8 +209,11 @@ private function buildQualification(): Qualification {
 
 	// TODO
 	private static function genQualificationValue( ?string $flag = null ): int {
-		assert( is_string( $flag ) );
-		return (int)( self::$map[$flag] ?? 0 );
+		if ( !is_string( $flag ) || !isset(self::$map[$flag]) ) {
+			throw new InvalidArgumentException( 'Qualifier is incorrect' );
+		}
+
+		return (int)self::$map[$flag];
 	}
 
 	private function buildSet( string $input ): Set {

diff --git a/tests/Unit/PackagePrivate/Parser/ParserTest.php b/tests/Unit/PackagePrivate/Parser/ParserTest.php
@@ -292,4 +292,27 @@ public function setOpenMiddleNonExtDateValues(): array {
 			[ "{2000%..2000-02}", "Dates in set ranges cannot be uncertain" ],
 		];
 	}
+
+	/**
+	 * @dataProvider setCombinedUncertainAndApproximateQualifiers
+	 */
+	public function testThrowExceptionWhenUsedCombinedUncertainAndApproximateQualifiers( string $combinedUncertainAndApproximate ): void {
+		$parser = new Parser();
+		$this->expectException( InvalidArgumentException::class );
+		$this->expectExceptionMessage( 'Invalid edtf format ' . $combinedUncertainAndApproximate );
+		$parser->createEdtf( $combinedUncertainAndApproximate );
+	}
+
+	public function setCombinedUncertainAndApproximateQualifiers(): array {
+		return [
+			[ '1990?~' ],
+			[ '1990~?' ],
+			[ '?~1990}' ],
+			[ '~?1990' ],
+			[ '1990-02~?' ],
+			[ '1990-?~02' ],
+			[ '1990-?~02~?-03' ],
+			[ '1990-02-~?03' ],
+		];
+	}
 }