fork from "rc" branch #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When resizing/moving, now take window's infos from chrome.windows.get()
The commits in #191 introduced a regression - see See #186 (comment) This reverts commit 770fe82. This reverts commit e42ea32.
Translation of the interface into Russian.
stores the correct values for size and position stores the state of the window restores the state of the window when TF is opened
When `tabOnCreated` is called, `ctab.url` is `""`, and the URL is in [`ctab.pendingUrl`] instead. Check `pendingUrl` to look for the tab's node ID. Also still check `url` first, to support Chrome pre-79. [ctab.pendingUrl]: https://developer.chrome.com/extensions/tabs#property-Tab-pendingUrl
Since ctab.pendingUrl now exists, use it as a backup to url throughout.
If S.ISSUE35 is true, partial-window behaviour is turned on. This commit adds S.ISSUE35, updates the settings accordingly, and updates some of main_tl.js accordingly.
Also a pendingUrl issue.
Remove some uses of /\btab\b/ to reduce confusion of when we are talking about ctabs and when we are talking about other tab data structures.
- The last saved geometry persists until the window has a different geometry _and_ is in the `normal` state. - The window is assumed to start out in the `normal` state, which seems to be what Chrome does. (Is it what Vivaldi does when the TF panel is docked, though?) - Bump the resize debouncing interval from 200 ms to 300 ms per my own empirical testing. - Added utility functions K.dups(), ErrorMessageString().
- Remove the changelog entry for reopened #186 - Bump version number
Change the settings and CSS to clip anchor elements to within the window. This improves but does not fully fix #201. Also includes whitespace changes.
It's what I'm more accustomed to typing! :)
acorn: Indirect dev dependency: brunch->deppack->detective->acorn. minimist: several places, including babel-brunch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new branch based on current code "rc" (as of 20200429).