Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement framer-motion for added interactivity #45

Merged
merged 4 commits into from
Aug 18, 2023

Conversation

diogomufasa
Copy link
Contributor

Added a useful UX library for the project

I suggest using framer-motion for added interactivity, I made a small change to the navigationLinks component as an example.
For more info on this library visit the official docs here.

I hope you liked the suggestion 👍🏽

@vercel
Copy link

vercel bot commented Aug 15, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @PriyansuMaurya on Vercel.

@PriyansuMaurya first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @diogomufasa! 🎉 Thank you for submitting your first pull request. Your contribution is extremely valuable, and we are grateful for your dedication to improving our project. We recognize your hard work and commitment. Keep up the excellent job!

We will promptly review your changes and provide helpful feedback. Please remember to review our contributing guidelines. Thank you again for your contributions!

@vercel
Copy link

vercel bot commented Aug 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aifusion ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 18, 2023 0:46am

@PriyansuMaurya
Copy link
Owner

It is affecting the UI on the desktop.

Try making the hover size subtle on desktop so that it doesn't cause any issues. BTW, It looks amazing on mobile phones.

Before

image

After Hover

image

@PriyansuMaurya
Copy link
Owner

Changing the scale from 1.1 to 1.09 doesn't make much of a difference. The problem still persists. Adjust it so that on desktop mode, it is 1.02, and on mobile or tablets, it is 1.1.

@PriyansuMaurya
Copy link
Owner

I find everything to be in good order. We just require one final confirmation from @Ameya02, and upon receiving it, I will proceed with the merge.

@PriyansuMaurya PriyansuMaurya changed the title Implement framer-motion for added interactivity feat: Implement framer-motion for added interactivity Aug 18, 2023
@PriyansuMaurya PriyansuMaurya merged commit aa4f862 into PriyansuMaurya:main Aug 18, 2023
4 of 5 checks passed
@diogomufasa diogomufasa deleted the framer_motion branch August 19, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants