Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: toggle button background in light mode #31

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

AlimurtuzaCodes
Copy link
Contributor

@AlimurtuzaCodes AlimurtuzaCodes commented Jun 21, 2023

PR

Issue Number: #30

Fixed background color to green in light mode of toggle button.

@vercel
Copy link

vercel bot commented Jun 21, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @PriyansuMaurya on Vercel.

@PriyansuMaurya first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @CYBWEBALI! 🎉 Thank you for submitting your first pull request. Your contribution is extremely valuable, and we are grateful for your dedication to improving our project. We recognize your hard work and commitment. Keep up the excellent job!

We will promptly review your changes and provide helpful feedback. Please remember to review our contributing guidelines. Thank you again for your contributions!

@AlimurtuzaCodes AlimurtuzaCodes changed the title FIX: Toggle Button Background in Light Mode [FIX]: Toggle Button Background in Light Mode Jun 21, 2023
@AlimurtuzaCodes AlimurtuzaCodes changed the title [FIX]: Toggle Button Background in Light Mode fix: Toggle Button Background in Light Mode Jun 21, 2023
@AlimurtuzaCodes AlimurtuzaCodes changed the title fix: Toggle Button Background in Light Mode fix: toggle button background in light mode Jun 21, 2023
@vercel
Copy link

vercel bot commented Jun 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aifusion ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2023 11:08am

@PriyansuMaurya
Copy link
Owner

PriyansuMaurya commented Jun 21, 2023

Current:

image

Your changes:

image

If you look closely, your changes do not seem to be consistent with the overall UI.

I have checked all the available options.

image

But I think old one is very consistent with the UI. So, I would say go with the old one and keep the size to 30

image

@Ameya02
Copy link
Collaborator

Ameya02 commented Jun 22, 2023

@CYBWEBALI please make the changes given by @PriyansuMaurya and update the PR

@AlimurtuzaCodes
Copy link
Contributor Author

Hence there are no changes you can close this pr

@rajkaranm
Copy link
Collaborator

Hey Thanks for contribution but this issue can be solved by just adding

className="text-[color:var(--primary-color)]"

To Navbar component in line 22, this line add class of color to --primary-color which green by tailwind. Hope you understood and just change color don't change fontSize of the icon.

@AlimurtuzaCodes
Copy link
Contributor Author

Hey Thanks for contribution but this issue can be solved by just adding

className="text-[color:var(--primary-color)]"

To Navbar component in line 22, this line add class of color to --primary-color which green by tailwind. Hope you understood and just change color don't change fontSize of the icon.

Current Output after adding this line:
image

Expected Ouput:
image

@PriyansuMaurya
Copy link
Owner

PriyansuMaurya commented Jun 22, 2023

Hence, there are no changes. You can close this PR.

Thanks for your patience, @CYBWEBALI.

I just checked myself, and now I understand that this problem cannot be solved with the current icon, BsToggleOff.

Check out this repository, I think it could solve this issue: https://github.com/clari/react-ios-switch.

@AlimurtuzaCodes
Copy link
Contributor Author

AlimurtuzaCodes commented Jun 22, 2023

I just did a small fix,I just rotated the BsToggleOn and I have achieved what we wanted.
image
image
image

If it is Ok then I will create New PR for this

@PriyansuMaurya
Copy link
Owner

Great! Create a new PR.

@AlimurtuzaCodes
Copy link
Contributor Author

AlimurtuzaCodes commented Jun 22, 2023

Updated This PR Only.

Copy link
Collaborator

@Ameya02 Ameya02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@PriyansuMaurya
Copy link
Owner

PriyansuMaurya commented Jun 22, 2023

@CYBWEBALI , You nailed this pull request! Keep up the good work.

@PriyansuMaurya PriyansuMaurya merged commit de3535e into PriyansuMaurya:main Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants