Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added spanish location to bleeding branch #275

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

vicentefelipechile
Copy link

No description provided.

@rbluer
Copy link
Collaborator

rbluer commented Sep 26, 2024

Thanks for changing the target of the pull request!
I'll pull it in now.

But one thing I just noticed is that for some of those language files you changed the order of the messages, and even deleted a few lines. That's fine for now. But eventually I will have to go back and restore the deleted lines and move the lines back to where they originally were. Why? Because sometimes when I'm adding new messages to the modules, I have to ensure they all align for all of the languages, otherwise, what I've found is that some translations may be missing a few messages, or if things need to be updated, the updates can get lost if they are in a different location. So basically, by keeping them all in the same order, with the same spacings between the groups, I can quickly go through all of the various languages to see if updates need to be applied.

I'm explaining this so you'll understand, but please don't worry about changing them if you don't want to. They're fine as they are, and I do greatly appreciated your help on this! :)

@rbluer rbluer merged commit 6c41b80 into PrisonTeam:bleeding Sep 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants