Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zh-CN.properties #269

Closed
wants to merge 2 commits into from
Closed

Conversation

SnowCutieOwO
Copy link

idk why but there's bunch corrupted code, I fixed it and re-translated some of them as the original wasn't very good

idk why but there's bunch corrupted code, I fixed it and re-translated some of them as the original wasn't very good
@rbluer
Copy link
Collaborator

rbluer commented Sep 14, 2024

I'm just seeing your pull request now. Sorry for the delay.

Thank you for providing some updates to this file! We greatly appreciate your help!

You mentioned that some of the messages appeared to be corrupted? I've seen this before when someone might have edited the file without using UTF-8. I could have caused that issue when adding new messages to this group.

Can you please reissue your pull request to PrisonTeam:bleeding? The PrisonTeam:master is protected and we do not want to pull anything directly in to it, without first testing within our bleeding branch.

If you need anything, or want to discuss this, please reach out to me on our discord server.

Thanks for your help!
RoyalBlueRanger

@SnowCutieOwO
Copy link
Author

SnowCutieOwO commented Sep 15, 2024

I'm just seeing your pull request now. Sorry for the delay.

Thank you for providing some updates to this file! We greatly appreciate your help!

You mentioned that some of the messages appeared to be corrupted? I've seen this before when someone might have edited the file without using UTF-8. I could have caused that issue when adding new messages to this group.

Can you please reissue your pull request to PrisonTeam:bleeding? The PrisonTeam:master is protected and we do not want to pull anything directly in to it, without first testing within our bleeding branch.

If you need anything, or want to discuss this, please reach out to me on our discord server.

Thanks for your help!
RoyalBlueRanger

Whoa! Thanks for reply, and I would happy to if you could give me the link of repo :) I'll check it later

@rbluer
Copy link
Collaborator

rbluer commented Sep 20, 2024

It's this one... same repo, just different branch. You may be able to just change the target branch on the PR? I cannot change that myself, but you may?

https://github.com/PrisonTeam/Prison/tree/bleeding

@SnowCutieOwO
Copy link
Author

It's this one... same repo, just different branch. You may be able to just change the target branch on the PR? I cannot change that myself, but you may?

https://github.com/PrisonTeam/Prison/tree/bleeding

Good, I'll close this pull quest and open another one :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants