Placeholder bug: The placeholder 'prison_rankup_cost_percent' uses th…

…e calculated value of a percentage, but when used with the placeholder attribute, it was found to use the price instead. As such, the actual value returned for the placeholder was incorrect.
PrisonTeam · Apr 21, 2024 · 917ef27 · 917ef27
1 parent 5dc094f
commit 917ef27
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/docs/changelog_v3.3.x.md b/docs/changelog_v3.3.x.md
@@ -14,7 +14,10 @@
 These change logs represent the work that has been going on within prison. 
 
 
-# 3.3.0-alpha.16c 2024-04-07
+# 3.3.0-alpha.16c 2024-04-20
+
+
+* **Placeholder bug: The placeholder 'prison_rankup_cost_percent' uses the calculated value of a percentage, but when used with the placeholder attribute, it was found to use the price instead.**  As such, the actual value returned for the placeholder was incorrect.
 
 
 * **Player Manager: Secondary Placeholders:  Setup the secondary placeholder support on the PlayerManager, but it has not been enabled yet** since secondary placeholders on placeholders do not make a lot of sense because each placeholder is only one value and they cannot contain alternative text.  At least not yet.

diff --git a/prison-ranks/src/main/java/tech/mcprison/prison/ranks/managers/PlayerManager.java b/prison-ranks/src/main/java/tech/mcprison/prison/ranks/managers/PlayerManager.java
@@ -729,7 +729,7 @@ public String getPlayerNextRankCostPercent( RankPlayer rankPlayer, String ladder
 
     			        	if ( attributeNFormat != null ) {
 
-    			        		sb.append( attributeNFormat.format( cost ) );
+    			        		sb.append( attributeNFormat.format( percent ) );
     			        	}
     			        	else {
-Original file line number
+Diff line change
@@ Expand Up @@
         			        	if ( attributeNFormat != null ) {
-        			        		sb.append( attributeNFormat.format( cost ) );
+        			        		sb.append( attributeNFormat.format( percent ) );
         			        	}
         			        	else {
@@ Expand Down @@