Rankup messages: externalized another message related to an economy f…

…ailure.
PrisonTeam · Jul 8, 2024 · 290bbdb · 290bbdb
1 parent 78fc846
commit 290bbdb
Show file tree

Hide file tree

Showing 8 changed files with 26 additions and 10 deletions.
diff --git a/docs/changelog_v3.3.x.md b/docs/changelog_v3.3.x.md
@@ -14,7 +14,10 @@
 These change logs represent the work that has been going on within prison. 
 
 
-# 3.3.0-alpha.18b 2024-07-07
+# 3.3.0-alpha.18b 2024-07-08
+
+
+* **Rankup messages: externalized another message related to an economy failure.***
 
 
 * **Mine bombs: Update and fix some issues with the new mine bomb processing and animations.**

diff --git a/prison-core/src/main/resources/lang/ranks/en_US.properties b/prison-core/src/main/resources/lang/ranks/en_US.properties
@@ -72,7 +72,7 @@
 ##       be able to enable them.
 
 
-messages__version=29
+messages__version=30
 messages__auto_refresh=true
 
 ranks_rankup__rankup_no_player_name=You have
@@ -94,6 +94,7 @@ ranks_rankup__rankup_no_ranks=There are no ranks in this ladder.
 ranks_rankup__rankup_rank_does_not_exist=The rank %1 does not exist on this server.
 ranks_rankup__rankup_rank_is_not_in_ladder=The rank %1 does not exist in the ladder %2.
 ranks_rankup__rankup_currency_is_not_supported=The currency, %1, is not supported by any loaded economies.
+ranks_rankup__rankup_economy_failed=Failed to adjust player's balance. Could be an issue with vault or a cache timing issue. Try again.
 ranks_rankup__rankup_ladder_removed=The ladder %1 was removed.
 ranks_rankup__rankup_failure_removing_ladder=Rankup failed since the player could not be removed from the ladder %1. (Players cannot be removed from the 'default' ladder).
 ranks_rankup__rankup_in_progress_failure=Rankup failed to complete normally. No status was set.

diff --git a/prison-core/src/main/resources/lang/ranks/fr_FR.properties b/prison-core/src/main/resources/lang/ranks/fr_FR.properties
@@ -72,7 +72,7 @@
 ##       be able to enable them.
 
 
-messages__version=28
+messages__version=29
 messages__auto_refresh=true
 
 ranks_rankup__rankup_no_player_name=Tu as
@@ -94,6 +94,7 @@ ranks_rankup__rankup_no_ranks=Il n'y a pas de rangs dans ce classement.
 ranks_rankup__rankup_rank_does_not_exist=Le rang %1 n'existe pas dans ce serveur.
 ranks_rankup__rankup_rank_is_not_in_ladder=Le rang %1 n'existe pas dans le classement %2.
 ranks_rankup__rankup_currency_is_not_supported=La monnaie, %1, n'est pas supporté par aucun plugin d'économie chargé. 
+ranks_rankup__rankup_economy_failed=Failed to adjust player's balance. Could be an issue with vault or a cache timing issue. Try again.
 ranks_rankup__rankup_ladder_removed=Le classement %1 a été supprimé.
 ranks_rankup__rankup_failure_removing_ladder=La montée en rang a échoué comme le joueur n'a pas pu être supprimé du classement. (Les joueurs ne peuvent pas être supprimés du classement 'default').
 ranks_rankup__rankup_in_progress_failure=La montée en rang n'a pas réussi à se terminer correctement. Aucun statut n'a été défini.

diff --git a/prison-core/src/main/resources/lang/ranks/pt_PT.properties b/prison-core/src/main/resources/lang/ranks/pt_PT.properties
@@ -72,7 +72,7 @@
 ##       be able to enable them.
 
 
-messages__version=6
+messages__version=7
 messages__auto_refresh=true
 
 ranks_rankup__rankup_no_player_name=Tu têns
@@ -94,6 +94,7 @@ ranks_rankup__rankup_no_ranks=Não existe ranks nesta ladder.
 ranks_rankup__rankup_rank_does_not_exist=O rank %1 não existe neste server.
 ranks_rankup__rankup_rank_is_not_in_ladder=O rank %1 não existe naladder %2.
 ranks_rankup__rankup_currency_is_not_supported=A economia não é suportada, %1.
+ranks_rankup__rankup_economy_failed=Failed to adjust player's balance. Could be an issue with vault or a cache timing issue. Try again.
 ranks_rankup__rankup_ladder_removed=A ladder %1 foi removida.
 ranks_rankup__rankup_failure_removing_ladder=Rankup falhou porque  nao foi possivel remover o player da ladder %1. (Players cannot be removed from the 'default' ladder).
 ranks_rankup__rankup_in_progress_failure=Rankup falhou ser complet corretamente.

diff --git a/prison-core/src/main/resources/lang/ranks/zh-CN.properties b/prison-core/src/main/resources/lang/ranks/zh-CN.properties
@@ -72,7 +72,7 @@
 ##       be able to enable them.
 
 
-messages__version=25
+messages__version=26
 messages__auto_refresh=true
 
 ranks_rankup__rankup_no_player_name=你已经
@@ -92,6 +92,7 @@ ranks_rankup__rankup_failed_to_assign_rank_with_refund=分配阶级失败.  重
 ranks_rankup__rankup_failed_to_save_player_file=无法检索或写入数据，您的文件可能已损坏，通知服务器管理员
 ranks_rankup__rankup_no_ranks=这个矿区上没有阶级
 ranks_rankup__rankup_rank_does_not_exist=阶级%1不存在
+ranks_rankup__rankup_economy_failed=Failed to adjust player's balance. Could be an issue with vault or a cache timing issue. Try again.
 ranks_rankup__rankup_rank_is_not_in_ladder=阶级%2中不存在阶级%1
 ranks_rankup__rankup_currency_is_not_supported=任何已加载的经济前置都不支持货币%1
 ranks_rankup__rankup_ladder_removed=已删除阶级%1

diff --git a/prison-core/src/main/resources/lang/ranks/zh_TW.properties b/prison-core/src/main/resources/lang/ranks/zh_TW.properties
@@ -72,7 +72,7 @@
 ##       be able to enable them.
 
 
-messages__version=9
+messages__version=10
 messages__auto_refresh=true
 
 ranks_rankup__rankup_no_player_name=您已經
@@ -94,6 +94,7 @@ ranks_rankup__rankup_no_ranks=這個階內沒有階級
 ranks_rankup__rankup_rank_does_not_exist=階級 %1 不存在
 ranks_rankup__rankup_rank_is_not_in_ladder=此階級 %1 不存在於階 %2 之中
 ranks_rankup__rankup_currency_is_not_supported=這個貨幣, %1, 無法使用於此
+ranks_rankup__rankup_economy_failed=Failed to adjust player's balance. Could be an issue with vault or a cache timing issue. Try again.
 ranks_rankup__rankup_ladder_removed=階 %1 已經刪除
 ranks_rankup__rankup_failure_removing_ladder=Rankup failed since the player could not be removed from the ladder %1. (Players cannot be removed from the 'default' ladder).
 ranks_rankup__rankup_in_progress_failure=無法正常的升級. 此階級不存在

diff --git a/prison-ranks/src/main/java/tech/mcprison/prison/ranks/commands/RankUpCommand.java b/prison-ranks/src/main/java/tech/mcprison/prison/ranks/commands/RankUpCommand.java
@@ -1279,10 +1279,10 @@ public void processResults( CommandSender sender, String playerName,
 				break;
 
 			case RANKUP_FAILURE_ECONOMY_FAILED:
-				// TODO externalize message
-				String msg = "Failed to adjust player's balance. Could be an issue with vault or " +
-						"a cache timing issue. Try again.";
-				sender.sendMessage( results.getRankPlayer().convertStringPlaceholders( msg ) );
+				ranksRankupFailureEconomyFailedMsg( sender, results.getRankPlayer() );
+				//String msg = "Failed to adjust player's balance. Could be an issue with vault or " +
+				//		"a cache timing issue. Try again.";
+				//sender.sendMessage( results.getRankPlayer().convertStringPlaceholders( msg ) );
 
 				break;
 

diff --git a/prison-ranks/src/main/java/tech/mcprison/prison/ranks/commands/RankUpCommandMessages.java b/prison-ranks/src/main/java/tech/mcprison/prison/ranks/commands/RankUpCommandMessages.java
@@ -557,6 +557,14 @@ protected void ranksRankupFailureCurrencyIsNotSupportedMsg( CommandSender sender
 				.sendTo( sender, rPlayer );
 	}
 
+	protected void ranksRankupFailureEconomyFailedMsg( CommandSender sender, 
+			RankPlayer rPlayer ) {
+
+		PrisonRanks.getInstance().getRanksMessages()
+		.getLocalizable( "ranks_rankup__rankup_economy_failed" )
+		.sendTo( sender, rPlayer );
+	}
+
 	protected void ranksRankupFailureLadderRemovedMsg( CommandSender sender, 
 			String ladder, 
 			RankPlayer rPlayer ) {