Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use getter for .heldItem #73

Merged
merged 1 commit into from
Dec 30, 2023
Merged

Use getter for .heldItem #73

merged 1 commit into from
Dec 30, 2023

Conversation

szdytom
Copy link
Contributor

@szdytom szdytom commented Nov 1, 2023

Uses getter function for .heldItem.

related to PrismarineJS/mineflayer#3224

@szdytom szdytom mentioned this pull request Nov 2, 2023
Merged
@rom1504
Copy link
Member

rom1504 commented Dec 17, 2023

are you sure this is always valid? for example what about the second hand ?

@szdytom
Copy link
Contributor Author

szdytom commented Dec 17, 2023

The document(and the README of this repository) says .heldItem is equivalent to .equipment[0], so why not to use a getter?

@rom1504 rom1504 merged commit 4694438 into PrismarineJS:master Dec 30, 2023
2 checks passed
@rom1504
Copy link
Member

rom1504 commented Dec 30, 2023

/makerelease

@rom1504bot rom1504bot mentioned this pull request Dec 30, 2023
Merged
@szdytom szdytom deleted the helditem-with-getter branch June 7, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
PR Triage
Status: Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szdytom @rom1504