Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add brewing stand methods #2944

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

Conversation

Jovan-04
Copy link
Contributor

@Jovan-04 Jovan-04 commented Feb 14, 2023

similar to the furnace methods, but for brewing stands

not ready to merge, but figured i had a good start and would make a pr.

there are still some problems with different mc versions. pre-1.9 doesn't need blaze powder as fuel for brewing, so the fuel property returns the wrong item, and the takeFuel() and putFuel() methods error out in an unhelpful way.

post-1.9 also has different issues with the fuel gui. the windowUpdate event doesn't pass through any information about the gui besides the slots, so the current fuel level stays undefined until it gets updated.

Copy link
Member

@extremeheat extremeheat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing:

  • tests
  • doc
  • example

@Jovan-04 Jovan-04 marked this pull request as draft February 14, 2023 17:43
@Jovan-04
Copy link
Contributor Author

yeah, i still have some more work to do before it'll be fully functional. i'll write up a quick doc today, and i'll make an example once i get everything working.

what do you mean by tests?

@rom1504
Copy link
Member

rom1504 commented Feb 14, 2023 via email

@Jovan-04
Copy link
Contributor Author

Jovan-04 commented Mar 4, 2023

from what I've been able to tell, the issues are arising from the test I wrote. I'm not sure if that's an issue with the tests themselves, or an issue with the underlying plugin that the tests are just exposing. I've been pretty busy with classes and midterms lately, which is why there hasn't been much progress. as of right now, my plan is to update the test so that it uses bot.supportFeature instead of strict version checking (which i think will involve an update to mc-data), then add some more checks in the test.

@extremeheat
Copy link
Member

You can try commenting out some of the code in the test and see what lines cause the errors, that will help debug the issues

@rom1504
Copy link
Member

rom1504 commented Jul 29, 2023

looks like this is not far from merging

@Jovan-04 can you fix 1.8 tests ?

@rom1504
Copy link
Member

rom1504 commented Dec 31, 2023

@Jovan-04 any time to finish it now by any chance :) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs triage
Development

Successfully merging this pull request may close these issues.

3 participants