Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banish callbacks to the shadow realm #248

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

IceTank
Copy link
Collaborator

@IceTank IceTank commented Feb 19, 2022

No description provided.

@IceTank IceTank requested a review from u9g February 19, 2022 12:34
@rom1504
Copy link
Member

rom1504 commented Feb 19, 2022

yeah let's do that
this should prob go in a 2.0.0 though

do you know if many people use callbacks with pathfinder?

Copy link
Member

@u9g u9g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@IceTank
Copy link
Collaborator Author

IceTank commented Feb 19, 2022

do you know if many people use callbacks with pathfinder?

I am not sure. But there was not really anything besides goto that used callbacks. Goto is a somewhat newer feature. So I don't think any older plugins use it.

@rom1504 rom1504 merged commit 3d45ada into PrismarineJS:master Mar 8, 2022
@IceTank IceTank deleted the remove-callbacks branch March 8, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants