Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.21: Add some data #927

Merged
merged 8 commits into from
Oct 26, 2024
Merged

1.21: Add some data #927

merged 8 commits into from
Oct 26, 2024

Conversation

GroobleDierne
Copy link
Contributor

@GroobleDierne GroobleDierne commented Oct 17, 2024

Added blocks, enchantments, foods, language, materials, recipes & tints
Made some corrections to protocol.json

It also fixes the "category" field being sometimes incorrectly set in 1.20.5/items.json

@GroobleDierne GroobleDierne marked this pull request as ready for review October 17, 2024 18:03
@GroobleDierne
Copy link
Contributor Author

It's ready for me if no changes are requested

@rom1504
Copy link
Member

rom1504 commented Oct 19, 2024

why is this pr changing 1.20.5 ?

@GroobleDierne
Copy link
Contributor Author

Some data regarding enchantments were wrong, things like "category": "tagkey[minecraft:item / minecraft:enchantable/foot_armor]" instead of "category": "foot_armor",

@rom1504 rom1504 merged commit 8d2793f into PrismarineJS:pc1.21 Oct 26, 2024
2 checks passed
rom1504 added a commit that referenced this pull request Oct 26, 2024
* Add pc 1.21 protocol data

* fix

* Update dataPaths.json

* to 1.21.1

* Fix packet_explosion

* Fix ChatTypes

* Fix SlotComponentType missing repair_cost

* 1.21: Add some data (#927)

* 1.21: add blocks enchantments foods language materials & tints

* Fix enchantment category

* 1.20.5: fix enchantCategories

* 1.21: Add items.json

* Add update informations for foods.json

* 1.21: Add recipes.json

* 1.21: protocol.json fix vibration particle

* 1.21.1: Add sounds.json

* add default in packet explosion switch for sound id

* use empty container instead of void in packet explosion so it works well with anon top level

* also on 1.20.5

* recipes should have null not -1

---------

Co-authored-by: Romain Beaumont <romain.rom1@gmail.com>
Co-authored-by: Grooble <grooble.dierne@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants