-
-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.21: Add some data #927
Merged
Merged
1.21: Add some data #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's ready for me if no changes are requested |
This was referenced Oct 18, 2024
Merged
why is this pr changing 1.20.5 ? |
Some data regarding enchantments were wrong, things like |
rom1504
added a commit
that referenced
this pull request
Oct 26, 2024
* Add pc 1.21 protocol data * fix * Update dataPaths.json * to 1.21.1 * Fix packet_explosion * Fix ChatTypes * Fix SlotComponentType missing repair_cost * 1.21: Add some data (#927) * 1.21: add blocks enchantments foods language materials & tints * Fix enchantment category * 1.20.5: fix enchantCategories * 1.21: Add items.json * Add update informations for foods.json * 1.21: Add recipes.json * 1.21: protocol.json fix vibration particle * 1.21.1: Add sounds.json * add default in packet explosion switch for sound id * use empty container instead of void in packet explosion so it works well with anon top level * also on 1.20.5 * recipes should have null not -1 --------- Co-authored-by: Romain Beaumont <romain.rom1@gmail.com> Co-authored-by: Grooble <grooble.dierne@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added blocks, enchantments, foods, language, materials, recipes & tints
Made some corrections to protocol.json
It also fixes the "category" field being sometimes incorrectly set in 1.20.5/items.json