-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ModelExporter #24
Conversation
Hi, I see you just added a separate git repositiry inside of this repository. Please PR new files into the existing repository instead of making a brand new repository and new mod. |
This code also only works with 1.21. You need to add a file for every version 1.7-1.21 |
Multi version implementations would be nice if you have the time to write it but it's not a requirement as it's not required by anything in PrismarineJS at the moment. |
I'm on macOS and cannot compile 1.12.2 version, so i added separate project that i can build.
Also I'm using mojang mappings because we shouldn't be dependent of one technology like fabric (I'm talking about yarn mappings) |
Entities don't differ much from version to version and I don't have time to implement this on legacy versions. |
This commit will fix it: 5757961
The team uses yarn because it is consistent from 1.7.-1.21. Being despondent on fabric is good here since it helps maintaining the project. |
There are enough differences to warrant a implementation per version. But only for 1.21 should be sufficient as extremeheat said. |
Please add the code to the 1.21 module instead of adding a brand new submodule. |
Merge your PR then I can work on this PR UPD: I just compied few lines from build.gradle |
Another issue on macOS after resetting entire gradle cache:
|
Is this still useful? If yes then please finish it |
@@ -6,7 +6,7 @@ plugins { | |||
} | |||
|
|||
unimined.minecraft { | |||
version "1.20.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not change the 1.20.5 module to 1.21. It needs to stay 1.20.5. For a new 1.21 generator please make a new 1.21 module.
Open another PR if you want this finished |
No description provided.