Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.20.5 update (this commit also includes updating gradle, fabric-loom) #19

Closed
wants to merge 4 commits into from

Conversation

qwqtoday
Copy link

No description provided.

@qwqtoday
Copy link
Author

ummm you need java 21 for this and of course running on lower versions with java 21 will not work

@qwqtoday qwqtoday changed the title 1.20.5 update (this commit also includes updating gradle, fabric-loom) 🚨🚨🚨 really important pr, hope you will merge asap 🚨 1.20.5 update (this commit also includes updating gradle, fabric-loom) May 31, 2024
@qwqtoday qwqtoday changed the title 🚨🚨🚨 really important pr, hope you will merge asap 🚨 1.20.5 update (this commit also includes updating gradle, fabric-loom) 1.20.5 update (this commit also includes updating gradle, fabric-loom) Jun 3, 2024
@rom1504
Copy link
Member

rom1504 commented Jul 13, 2024

conflicts with #18 which should we merge?

@rom1504 rom1504 mentioned this pull request Jul 13, 2024
@qwqtoday
Copy link
Author

conflicts with #18 which should we merge?

#18 should be merged first because it sounds more important to me

@rom1504
Copy link
Member

rom1504 commented Jul 14, 2024

Ok done, please rebase

@AlexProgrammerDE
Copy link
Collaborator

This PR can actually be closed. My reduce duplicate code PR also added 1.20.5.

@AlexProgrammerDE
Copy link
Collaborator

I'll make a PR for 1.21 now.

@qwqtoday qwqtoday closed this Jul 14, 2024
@qwqtoday
Copy link
Author

This PR can actually be closed. My reduce duplicate code PR also added 1.20.5.

Thanks bye

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants