1.17.1 support #650

Pandapip1 · 2024-01-08T17:59:31Z

Blocked by ~~PrismarineJS/diamond-square#15~~, PrismarineJS/prismarine-provider-anvil#73.

rom1504 · 2024-01-12T20:29:01Z

Looks like tests are passing.

Do things seem to work?

rom1504 · 2024-01-12T20:30:31Z

src/lib/plugins/world.js

          }
        }, // FIXME: fake heightmap
        chunkData: chunk.dump(),
        blockEntities: []
      })
-      if (registry.supportFeature('lightSentSeparately')) {
+      if (registry.supportFeature('dimensionDataIsAvailable')) {


The name of the feature seems unrelated with the content of this if

Copied directly from mineflayer code.

https://github.com/PrismarineJS/mineflayer/blob/5c71edf48bb2f2dfa16cddb9af5baa0c4d55cf0d/lib/plugins/blocks.js#L264 definitely has the same issue

Pandapip1 · 2024-01-12T22:03:18Z

Looks like tests are passing.

Do things seem to work?

THINGS DO NOT WORK. Particularly, world saving is completely borked and sometimes the server crashes when trying to send chunk packets (all to do with the palette set to null error).

rom1504 · 2024-01-14T16:32:29Z

I made PrismarineJS/prismarine-provider-anvil#74 which I think should fix this anvil problem

Can you check if that helps the error you were seeing @Pandapip1 ?

socket-security · 2024-01-14T16:32:31Z

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/prismarine-provider-anvil@2.7.0

View full report↗︎

Pandapip1 · 2024-01-14T22:32:20Z

I'm still getting the following error, even after updating:

January 14th 2024, 16:30:13 [ERROR]: -------------------------------
January 14th 2024, 16:30:13 [ERROR]: Please report this flying-squid! This is bug (mabye)
January 14th 2024, 16:30:13 [ERROR]: Something went wrong!
January 14th 2024, 16:30:13 [ERROR]: Error: TypeError: this.sectionMask.toLongArray is not a function
    at ChunkColumn.getMask (/home/gavin/repos/flying-squid/node_modules/prismarine-chunk/src/pc/1.17/ChunkColumn.js:244:31)
    at /home/gavin/repos/flying-squid/src/lib/plugins/world.js:188:23
    at Entity.behavior (/home/gavin/repos/flying-squid/src/lib/behavior.js:24:14)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async player.login (/home/gavin/repos/flying-squid/src/lib/plugins/login.js:222:5)
    at async Server.<anonymous> (/home/gavin/repos/flying-squid/src/lib/plugins/login.js:29:7)
January 14th 2024, 16:30:13 [ERROR]: Report this error here: https://github.com/PrismarineJS/flying-squid/issues
January 14th 2024, 16:30:13 [ERROR]: -------------------------------
January 14th 2024, 16:30:13 Server shutting down...

rom1504 · 2024-01-14T22:53:07Z

ok that's a different error than the palette

rom1504 · 2024-01-14T22:55:47Z

would be great to have a test showing this, would make it faster to debug

rom1504 · 2024-02-26T00:49:47Z

PrismarineJS/prismarine-provider-anvil#75 / PrismarineJS/prismarine-provider-anvil#73 is the blocker here

privt00 · 2024-03-29T14:27:17Z

hey
i think i made progress

getting now this error

March 29th 2024, 18:47:08 [ERROR]: Error: TypeError: this.skyLightMask.toLongArray is not a function
at ChunkColumn.dumpLight (C:\Users\Noah\Documents\mclient\node_modules\prismarine-chunk\src\pc\1.17\ChunkColumn.js:379:61)
at C:\Users\Noah\Documents\mclient\src\lib\plugins\world.js:245:20
at Entity.behavior (C:\Users\Noah\Documents\mclient\fly-high\src\lib\behavior.js:24:14)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

after world safe in 1.17.1 but yeah im tryng to fix it at moment i just dont know if its has somthing to do whit the anvil or just whit the chunkColumn.js

privt00 · 2024-03-29T14:31:14Z

i also try fixing redstone like piston activated and all stuff

privt00 · 2024-03-29T14:59:05Z

i fixed this error

privt00 · 2024-03-29T14:59:30Z

just need to fix the lightnigs

privt00 · 2024-03-29T16:31:28Z

ok made now the 1.17.1 support

privt00 · 2024-03-29T16:33:15Z

oh no relised world dosnt safe you just can join and build but nothing gets saved

privt00 · 2024-03-29T17:55:29Z

@rom1504 in which file is the savin logik?

rom1504 · 2024-03-29T20:02:28Z

This repo PrismarineJS/prismarine-provider-anvil#73

FabioSmuu · 2024-11-23T09:13:21Z

I'm coming to the conclusion that the problem is not in player.sendChunk, but in the generation of the chunk using Anvil

I could observe that at some moments, sectionMask and skyLightMask stop being a BitArray and become Number.

If you put a try/catch to temporarily hide this action, the world works perfectly, but it only renders what is in memory and some random chunks.

It is also noticeable that the map is not being saved and there is no log confirming that the save was made.

I thought about doing a /save command to force this action.

The conclusion I came to is that the creation of the chunk is breaking (it is obvious that you have also noticed, right?)

FabioSmuu · 2024-11-23T19:55:04Z

Apparently I discovered the problem with the chunks!

Because some BitArrays return as numbers, it ends up implying in the lighting dump.

The first thing I did regarding sectionMask is to just change Prismarine-Chunk so that the getMask method returns undefined if sectionMask is not an object (or a BitArray)

And for skyLightMask, you can simply ignore the supportFeature dimensionDataIsAvailable and lightSentSeparately (JUST FOR TESTING OK?)

Now, every time we turn on the server, the world will remain intact, but a new problem appears.

The new problem is that now, if a player joins/leaves the server (I'm not sure), the chunk automatically corrupts and the save will be empty.

Summary:
The problem is not in the save, but in the chunk.

Pandapip1@3416217

https://imgur.com/Fl7iJ6Q

FabioSmuu · 2024-11-23T23:39:37Z

I found something interesting.

The problem seems to be in world.js, but nothing related to chunk or anvil (but we can't rule out this hypothesis).

Look carefully at the save method of player.

If we put any item in the inventory and click to destroy it, it will work perfectly.

But if you log out of the server and log back in, you will notice that it will no longer be possible to destroy items in the inventory.

This problem only occurs if you follow these steps. I've tried restarting the server and it only works when the user logs back in.

Could the problem be with the player logging out or some save method?

rom1504 · 2024-11-24T00:05:08Z

I still think PrismarineJS/prismarine-provider-anvil#73 (comment) this is the issue

FabioSmuu · 2024-11-24T00:21:37Z

I'll follow your line of reasoning and explore Anvil then.

I'll explore 1.18 and see what I can adapt.

FabioSmuu · 2024-11-24T01:12:07Z

You're right @rom1504 , it's about the anvil

I just copied /src/1.14/chunk.js to create a completely modified one.

Writing chunk for 1.17.1 is being affected, the problem is in writing the chunks and not in reading them.

The test I just did was to copy the writeSections function from /src/1.18/chunk.js and make some adaptations.

The mask errors disappeared, now I just need to adapt them to save correctly, but now there are no crashes when rendering the map and no chunks are corrupted (not like before)

Gavin John added 2 commits January 8, 2024 11:59

Basic 1.17 support

1448f3c

Undo unneccesary changes

e9e178a

Pandapip1 mentioned this pull request Jan 8, 2024

1.17 worlds aren't writable PrismarineJS/prismarine-provider-anvil#73

Open

Gavin John added 6 commits January 8, 2024 16:59

standard.js lint

89eaca5

Undo some unnecessary changes

56a3f58

Always use loginPacket previousGameMode

5c988ff

Remove out-of-scope 1.18 changes

216d3cf

Update diamond-square

44e49c0

Use updated world generation

4df69e6

rom1504 marked this pull request as ready for review January 12, 2024 20:29

rom1504 reviewed Jan 12, 2024

View reviewed changes

Pandapip1 marked this pull request as draft January 12, 2024 22:03

use fixed anvil

f6a0c5d

rom1504 mentioned this pull request Mar 29, 2024

1.17-1.20 Support #545

Open

Merge branch 'master' into mc1.17

a46804d

Pandapip1 mentioned this pull request Apr 22, 2024

Add test to ensure that world data is saved #655

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

1.17.1 support #650

1.17.1 support #650

Pandapip1 commented Jan 8, 2024 •

edited

Loading

rom1504 commented Jan 12, 2024

rom1504 Jan 12, 2024

Pandapip1 Jan 12, 2024

rom1504 Jan 12, 2024

Pandapip1 commented Jan 12, 2024 •

edited

Loading

rom1504 commented Jan 14, 2024

socket-security bot commented Jan 14, 2024 •

edited

Loading

Pandapip1 commented Jan 14, 2024

rom1504 commented Jan 14, 2024

rom1504 commented Jan 14, 2024

rom1504 commented Feb 26, 2024

privt00 commented Mar 29, 2024 •

edited

Loading

privt00 commented Mar 29, 2024

privt00 commented Mar 29, 2024

privt00 commented Mar 29, 2024

privt00 commented Mar 29, 2024

privt00 commented Mar 29, 2024

privt00 commented Mar 29, 2024

rom1504 commented Mar 29, 2024

FabioSmuu commented Nov 23, 2024

FabioSmuu commented Nov 23, 2024 •

edited

Loading

FabioSmuu commented Nov 23, 2024

rom1504 commented Nov 24, 2024

FabioSmuu commented Nov 24, 2024

FabioSmuu commented Nov 24, 2024

1.17.1 support #650

Are you sure you want to change the base?

1.17.1 support #650

Conversation

Pandapip1 commented Jan 8, 2024 • edited Loading

rom1504 commented Jan 12, 2024

rom1504 Jan 12, 2024

Choose a reason for hiding this comment

Pandapip1 Jan 12, 2024

Choose a reason for hiding this comment

rom1504 Jan 12, 2024

Choose a reason for hiding this comment

Pandapip1 commented Jan 12, 2024 • edited Loading

rom1504 commented Jan 14, 2024

socket-security bot commented Jan 14, 2024 • edited Loading

Pandapip1 commented Jan 14, 2024

rom1504 commented Jan 14, 2024

rom1504 commented Jan 14, 2024

rom1504 commented Feb 26, 2024

privt00 commented Mar 29, 2024 • edited Loading

privt00 commented Mar 29, 2024

privt00 commented Mar 29, 2024

privt00 commented Mar 29, 2024

privt00 commented Mar 29, 2024

privt00 commented Mar 29, 2024

privt00 commented Mar 29, 2024

rom1504 commented Mar 29, 2024

FabioSmuu commented Nov 23, 2024

FabioSmuu commented Nov 23, 2024 • edited Loading

FabioSmuu commented Nov 23, 2024

rom1504 commented Nov 24, 2024

FabioSmuu commented Nov 24, 2024

FabioSmuu commented Nov 24, 2024

Pandapip1 commented Jan 8, 2024 •

edited

Loading

Pandapip1 commented Jan 12, 2024 •

edited

Loading

socket-security bot commented Jan 14, 2024 •

edited

Loading

privt00 commented Mar 29, 2024 •

edited

Loading

FabioSmuu commented Nov 23, 2024 •

edited

Loading