Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.16.5 support and future-proof version system #645

Merged
merged 46 commits into from
Jan 6, 2024

Conversation

Pandapip1
Copy link
Contributor

@Pandapip1 Pandapip1 commented Jan 4, 2024

Blocked by: PrismarineJS/minecraft-data#823; new version of node-minecraft-data Done!

Forked from #599. The author appears to have gone AWOL.

The goal of this PR is to add version support up to 1.18.2

Never mind. That will take a lot more time. For now, this has stable 1.16.5 support.

Fixes #447 and the following unreported minor issues:

  • Duplicate interaction registration on startup
  • Error when a client quits before chunks are loaded
  • Error when a client quits, at all

Closes #599

@Pandapip1 Pandapip1 changed the title [DRAFT] Add more modern version support Add 1.16.5 support and future-proof version system Jan 4, 2024
@Pandapip1 Pandapip1 marked this pull request as ready for review January 4, 2024 20:26
src/index.js Outdated Show resolved Hide resolved
src/lib/plugins/respawn.js Outdated Show resolved Hide resolved
src/lib/plugins/world.js Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
@rom1504
Copy link
Member

rom1504 commented Jan 4, 2024

left some more comments but most things look good besides that

@rom1504
Copy link
Member

rom1504 commented Jan 4, 2024

would be good if we can finally make progress on version supports for flying squid

@Pandapip1
Copy link
Contributor Author

We've got a green!

@Pandapip1 Pandapip1 requested a review from rom1504 January 4, 2024 23:57
@rom1504
Copy link
Member

rom1504 commented Jan 5, 2024

Left one comment about that onItemPlace

@Pandapip1 Pandapip1 requested a review from extremeheat January 6, 2024 03:59
@rom1504 rom1504 merged commit f776de8 into PrismarineJS:master Jan 6, 2024
14 checks passed
@rom1504
Copy link
Member

rom1504 commented Jan 6, 2024

Thanks for the PR.

There's a pretty big pile of new versions to get this to current: 1.17, 1.18, 1.19, 1.20
You can look at corresponding mineflayer PR to know what needs to be changed / implemented

@rom1504
Copy link
Member

rom1504 commented Jan 6, 2024

/makerelease

@rom1504bot rom1504bot mentioned this pull request Jan 6, 2024
@Pandapip1 Pandapip1 deleted the patch-1 branch January 7, 2024 14:15
@extremeheat extremeheat mentioned this pull request Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.16.2 and 1.16.3 support
4 participants