Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translator refactor + New Loved One title #72

Merged
merged 5 commits into from
Aug 20, 2017
Merged

Translator refactor + New Loved One title #72

merged 5 commits into from
Aug 20, 2017

Conversation

th0rgall
Copy link
Contributor

@th0rgall th0rgall commented Aug 17, 2017 •
edited
Loading

Adds a title to the new Loved one page.

Refactors the translator service to remove some coupling, the "translate" variable functionality is now abstracted into a method for better reusability & interface separation.

I tried to replace all calls of the old translator service, but there migth still be one in there.

! suggestion: remove node_modules after merging this one & rerun npm install because a lot updates & deletions have been made to the package.json.

@th0rgall th0rgall requested a review from oxnoctisxo August 17, 2017 22:24
oxnoctisxo
oxnoctisxo approved these changes Aug 20, 2017
View reviewed changes
Copy link
Contributor

@oxnoctisxo oxnoctisxo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it can really be done that way, that's good.

@oxnoctisxo oxnoctisxo merged commit 72461cb into develop Aug 20, 2017
@th0rgall th0rgall deleted the lovedone-title branch August 20, 2017 12:08
archived-m pushed a commit that referenced this pull request Sep 14, 2017
@blueclock
Merge playstore release to master (#112)
3909e8a 
* Static templates (#2)

* Adding static assets to work with

Addition of images +a stanizer so we can work with them

* Services declaration

Addition of a declaration for the stanize service (allows external images and videos to be safely linked)

* Static stories page made

Static stories page done according the Frederick's designs.

To make it dynamic we will need to link it to a back-end.

* Static Details page added.

You can now view the details of a story you selected.

* Update menu item copy and icon

* cleaner layout of stories overview

* Apply Varela web font

Using this guide: https://chriztalk.com/using-google-fonts-ionic-2/

* Use Roboto as second font

* Organize images

Folders for thumbs, small, medium and orginal.
Thumbs are square 150x150

* Cleaned up story overview layout

* Add all bottom menu items

* Rearrange story content and add comments

* Remove main padding and fix some padding bugs

* Back-end service

Added a back-end fetching service.

* Data model #3 (#7)

Data models, mock backend begin, tabs & tutorial.

* Create story #4 (#8)

Add action sheet to add a story, action sheet in tab, set up simple patient profile

* Addition of tabs and tutorials.

* Integrate mock-api data with frontend

* Update integration with mock api

* Tutorial Fixed and addition of a camera system.

A new library was added to the package.json file, it means you will need to do the command "npm -install" anew.

* Added new story page

* new story page

* demo

* Demo content & server route fixes.

* Demodata (#14)

Realistic content integrated.

* Model fix #5 (#16)

*changed data models, fixed and improved them.

* Origin/controllers (#18)

Story cleanup, add new story functionality, heritage semi-static page.

* Small adjustments to README (#17)

* Make small adjustments to the README

* Add Ionic installation instructions

* Add account links

* Also mention @fritsbits in the README

* Week two finalization (#19)

Add image, http fetched history overview, new color scheme, remove comments, remove profile page, "like" ==> "favorite"

* Merge fix: do not overwrite history albums

* Story redesign (#25)

* Camera fix + Roeselare version (#27)

* Issue #25 (#31)

New design views & controller improvements (more adapted to backend)

* Story detail redesign (#33)

* Album detail merge

* Story detail redesign & misc fixes

* Favorite stars implemented + more default styling variables

* New story design updates

* Glorious photo upload fix

* Backend API integration (#39)

Controller changes to integrate the new views with the real API, adding & updating stories, working photo upload, auth guard skeleton.

* Questions integration #34 (#48)

* Adds unit testing setup, initial questions service

* Adds a question controller

* Album images (#50)

Camera 100%, can add text only, fixed the unsanitazed images.
Closes #40

* Add album controller (#51)

* API with auth version (#54)

Tuesday 25/7 Frederik-demo version: login, auth, preloaded albums

* UI fixes #52 (#56)

* Multiple fixes

* Aesthetic/UI fixes - part 1

* Story actions below eachother

* Misc fixes #52 (#57)

* Multiple fixes

* Aesthetic/UI fixes - part 1

* Story actions below eachother

* Login fixes

* Favorite view in album detail

* Add new image

* Open Summer of Code final demo version (#62)

Misc styling changes, fake YouTube embeds (to be removed), story delete function, questions updates, basic FR/EN translations.

* FIxed login, fixed youtube and sin-up.

* Fixed youtube image

* Fixed image id

* Albums style fixes

* Fixed iFrame

* Can delete and logout

* Begin popover

* Story option further

* Fixes, youtube, fakestories, logout, swipe etc...

* Some cleanup

* Somemore cleanup

* Small changes

* Fixed string

* Many fixes

* Fixed update stories and details.

* Fixex , improvements and clean-ups.

* Many fixes/changes

* Question updates

* Question shuffle & cycle

* Added translation

* En trans

* Fixed

* Package json updates & translation hotfix

* Translated most things and added it in the menu

* Albums & album detail header redesign

* Youtube icon centered

* Translation completed + fixes

* Text backdrop

* Turn question strings into themes (#64)

* Turn question strings into themes

* Change all questions to themes

* l -> L

* Readme update (#63)

* README update

* Fix parentheses

* Add link to design research for the app

* Fix link to blog post with background info

* Adds a header image to replace the title

* Cleans, fixes and optimzation. (#65)

Cleans & fixes, new login/signup page design & validation.

* Revert "Cleans, fixes and optimzation. (#65)" (#66)

This reverts commit 7931cc4.

* Add link to wiki

* README.md link fixes & dev setup clarifications (#70)

* Cleans, fixes & login/signup rework (#67)

* Cleans, fixes and optimzation.

* Changed configs

* Improvement, Login page ramde, loader etc...

* Invitation controller

-Deactivated fakevideos
-Added invite request

* Login page and input styling

-Fixed auto-translation profile problems.
-Improved the email regex
-Input colors
-Fixed long bug where the password was cleared on re-focus
-The border on the bottom still has to be fixed , already lost 15 mins on that  so i'll try again some other time.

* Fixes loginPage

-Fixed on non-focused invalid input color
-Fixed line and colors
-Broder-bottom  problems almost fixed,  i'll see latter with @thorgalle1
-Made a gif: http://i.imgur.com/NsIRtFL.gifv

* Changes

* Button disabled

* merge started

* Merges with new-design, login & signup almost completed

* Removed Language choice view from login

* Invite ctrl

* New Loved One page, service fixes

* Delete unnecessary image assets from oSoc demo versions.

* Fix story description padding

* Navbar buttons refactor to a more Ionic-y way

* Hide language choice in app menu

* 1st step to the youtube system

-Adeed Youtube video selection menu
-Added Youtube video selection page

UI
-Changes dinamictly the title of the new story page

* Updated userDto and and added text tot the youtube description

* Invite and UI

-Small improvements here and there of Thor's  already good code
-UI changes in the menu
-invite page half-done

* Various tentives for async authorized images

Messy code

* Images with header, needs optimization and improvements

* Translator refactor + New Loved One title (#72)

* package.json ionic updates

* Translator changes, title in NewLovedonePage

* Translate service refactor fixes

* Removed www/mock-api - unused

* Removed temporary NewLovedone page menu test link

* More package.json updates (from Ionic deprecations)

* Smaller padding in albums view ==> more space for large words

* Removed unused imports

* images and optimization

* Removes unneeded translator variables

* Adds album tile gradient, favorite star drop shadow

* Private images implemented and optimized everywhere

* Many fixes

* Many fixes

* Topics on the bottom

* ChangeDetector best pratice

-ChangeDetectorBestPratice

* Optimization + loading background

Avoid reloading images as much as possible

* Topics on the bottom: almost done

* Makes translating multiple values more robust + login error copy in Dutch

* Debug, loader, optimization

* Fixes + improvements, invite and login

* Loading, invite and fixes

* Fixed expiration error

* Many fixes + real patient + real user.

* App name

* Many fixes , fully features youtube videos and more.

* Min password now 6 chars and max is 40

* wachtwoord not paswoord

* Make the inviterID dynamic

* Use instantiated AuthService

* Auth and login improved

* Many fixes & improvements.

-error message in invite.
-heritage images.
-add new loved one working.

* App versioning.

* Working app launch.

* Fixe

* Fixed trans

* To fix or not to fix, that is the question.

* Album reading fixe

Still not fixed but better.

* Fixed Album

* Update login.html (#106)

I don't remember why i didn't do it but it sounds good atm.

* LoginTimeout

* Timeout Fix

* Youtube video text align

* Add video padding and regex

* Padding and margin fix

* Image preview and upload

* Add new album fixed

* Ndls only

* Added youtube params

* Youtube + invite email.

* Update invite.html (#107)

Make the input on the email field , type email
This closes #99

* Checks if token expired

* Timeout error fix

* Timeout system callback function fix.

* Class var fix

* Loading screen shorter

* Language hard hard coded to nl

I made the translation code too well for my own good, had an hard time making it not work.

* Fixed spashscreen bug

* Quality error and sucess message for invite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxnoctisxo oxnoctisxo oxnoctisxo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@th0rgall @oxnoctisxo