Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-generic register for navigation with view-model #2257

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Non-generic register for navigation with view-model #2257

merged 1 commit into from
Dec 1, 2020

Conversation

nativenolde
Copy link
Contributor

@nativenolde nativenolde commented Nov 23, 2020

Description of Change

Allows developers to register views with view-models in a non-generic way.

API Addition

        /// <summary>
        /// Registers a Page for navigation.
        /// </summary>
        /// <param name="viewType">The Type of Page to register</param>
        /// <param name="viewModelType">The Type of ViewModel to use as the BindingContext for the Page</param>
        /// <param name="name">The unique name to register with the Page</param>
        /// <param name="containerRegistry"></param>
        public static void RegisterForNavigation(this IContainerRegistry containerRegistry, Type viewType, Type viewModelType, string name = null)

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

@dnfadmin
Copy link

dnfadmin commented Nov 23, 2020

CLA assistant check
All CLA requirements met.

@nativenolde nativenolde marked this pull request as ready for review November 23, 2020 20:25
Copy link
Member

@dansiegel dansiegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

@dansiegel dansiegel merged commit 54eaeba into PrismLibrary:master Dec 1, 2020
@nativenolde nativenolde deleted the register branch December 2, 2020 18:27
@dansiegel dansiegel added this to the Prism 8.1 milestone May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants