Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OberservesProperty support for PropertyChanged with string.empty #2202

Merged
merged 1 commit into from
Oct 1, 2020
Merged

OberservesProperty support for PropertyChanged with string.empty #2202

merged 1 commit into from
Oct 1, 2020

Conversation

brianlagunas
Copy link
Member

Description of Change

Added support for PropertyChanged events that pass string.Empty

Bugs Fixed

API Changes

none

Behavioral Changes

ObservesProperty will now invoke the command's CanExecute when passing string.Empty to the PropertyChanged event

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

dansiegel
dansiegel approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@dansiegel dansiegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@dansiegel dansiegel merged commit 66e5b93 into master Oct 1, 2020
@dansiegel dansiegel deleted the issue-2196 branch October 1, 2020 15:58
@brianlagunas brianlagunas mentioned this pull request Oct 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dansiegel dansiegel dansiegel approved these changes

Assignees
No one assigned
Labels
Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianlagunas @dansiegel