[BREAKING] Remove ILoggerFacade & entire Prism.Logging namespace #2176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Internally Prism didn't really do much logging outside of the deprecated Wpf Bootstrapper that was overly verbose. The little bit of logging that Prism was doing in the ModuleInitializer, ModuleManager and PageNavigationService ultimately is redundant as Prism provides mechanisms for capturing the raw exception object which is far more useful and can be logged directly by in the consuming application.
Issues
API Changes
Completely removes the Prism.Logging namespace and the few internal dependencies on it.
Behavioral Changes
Any app dependencies on ILoggerFacade will need to be updated.
PR Checklist