Make ViewModelLocator Opt-Out #2171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Updates Prism.Wpf & Prism.Uno to make the ViewModelLocator.AutowireViewModel property Opt-Out. This will now automatically set the value to true when creating the Shell, region content, or dialogs
Bugs Fixed
API Changes
Changed:
Behavioral Changes
Will now automatically set the ViewModelLocator.AutowireViewModel property to true if it has not been set. This WILL be most impactful for those who are injecting their ViewModel's into the ctor of their View. They will now have to either opt-out or remove the ctor injection. Failure to do so will result in the ViewModel being created multiple times.
This does NOT impact Views that are manually created and added to the Region.
PR Checklist