Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uno] Adjust UI Tests, force mono version for macOS builds #2090

Merged
merged 3 commits into from
Apr 23, 2020
Merged

[Uno] Adjust UI Tests, force mono version for macOS builds #2090

merged 3 commits into from
Apr 23, 2020

Conversation

jeromelaban
Copy link
Contributor

Description of Change

  • Aligns the UI Tests for using the default dialog after the removal of the custom dialog.
  • Use the set-runtime step to force the mono runtime version on macOS builds.

API Changes

None.

Behavioral Changes

None.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

@jeromelaban jeromelaban marked this pull request as draft April 23, 2020 21:26
@jeromelaban jeromelaban marked this pull request as ready for review April 23, 2020 21:31
@dansiegel dansiegel merged commit 291d1fe into PrismLibrary:master Apr 23, 2020
@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

1 similar comment
@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dansiegel dansiegel dansiegel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeromelaban @dansiegel