Create new Bootstrapper API #2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dansiegel
reviewed
Apr 21, 2020
dansiegel
reviewed
Apr 21, 2020
dansiegel
requested changes
Apr 21, 2020
Comment on lines
31
to
32
|
|
||
|
|
There was a problem hiding this comment.
should really be a single line of empty space
Comment on lines
33
to
46
| public void Run() | ||
| { | ||
| InitializeInternal(); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Run the initialization process. | ||
| /// </summary> | ||
| void InitializeInternal() | ||
| { | ||
| ConfigureViewModelLocator(); | ||
| Initialize(); | ||
| OnInitialized(); | ||
| } |
There was a problem hiding this comment.
this seems silly to me... really InitializeInternal is the Run... don't really see a point to having a public Run that is only calling an InitializeInternal
There was a problem hiding this comment.
Really just for consistency between the two approaches.
Comment on lines
166
to
168
| regionAdapterMappings.RegisterMapping(typeof(Selector), _containerExtension.Resolve<SelectorRegionAdapter>()); | ||
| regionAdapterMappings.RegisterMapping(typeof(ItemsControl), _containerExtension.Resolve<ItemsControlRegionAdapter>()); | ||
| regionAdapterMappings.RegisterMapping(typeof(ContentControl), _containerExtension.Resolve<ContentControlRegionAdapter>()); |
There was a problem hiding this comment.
this should be updated...
regionAdapterMappings.RegisterMapping<Selector, SelectorRegionAdapter>();
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
implemented a new bootstrapper API to replace the old legacy bootstrapper.
Bugs Fixed
API Changes
Added:
PR Checklist