Added XML Docs to Prism.Wpf - Prism.Services.Dialogs #2065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 17, 2020 21:28
Added documentation for every Dialog file except IDialogParameters/DialogParameters due to #2064
|
|
dansiegel
requested changes
Apr 19, 2020
Comment on lines
6
to
10
| /// The parameters from the dialog | ||
| /// The parameters passed to the dialog. |
There was a problem hiding this comment.
I believe this was correct to begin with... The DialogResult should be providing the DialogParameters from the Dialog... not to it..
There was a problem hiding this comment.
No problem, I thought the Parameters property in IDialogResult was the original parameters passed to the Dialog (IE IDialogAware.OnDialogOpened(parameters)), so I named it as such.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Added documentation - issue #1978
Project: Prism.Wpf
Namespace Prism.Services.Dialogs
Bugs Fixed
None
API Changes
None
Behavioral Changes
None
PR Checklist