Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding IContainerInfo #2060

Merged
merged 2 commits into from
Apr 16, 2020
Merged

Adding IContainerInfo #2060

merged 2 commits into from
Apr 16, 2020

Conversation

dansiegel
Copy link
Member

Description of Change

Adds new IoC interface for internal use by the RegionNavigationContentLoader. This simplifies the approach by no longer requiring a container specific implementation of the Content Loader. Currently each container needs to override a single method to locate the registered View type by inspecting the registrations for a given navigation segment (aka key). This change allows the entire implementation to now live in shared Platform code.

Prism.DryIoc.Wpf and Prism.Unity.Wpf now only contain some legacy Container extensions, the legacy Bootstrapper and PrismApplication.

fixes #2059

NOTE this is an internal use API and should not be generally consumed and will be in an internals namespace to further indicate it's internal use intent.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

Copy link
Member

@brianlagunas brianlagunas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Merge when the build passes

@brianlagunas brianlagunas merged commit 07997a6 into master Apr 16, 2020
@brianlagunas brianlagunas deleted the containerinfo branch April 16, 2020 19:41
@lock
Copy link

lock bot commented May 5, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Spec] Abstract Registration Lookup for Regions
2 participants